Skip to content

[#3302][Sub-Task] StarRocks catalog Partition ops #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2025
Merged

[#3302][Sub-Task] StarRocks catalog Partition ops #7791

merged 3 commits into from
Jul 30, 2025

Conversation

liunaijie
Copy link
Member

@liunaijie liunaijie commented Jul 24, 2025 •
edited
Loading

What changes were proposed in this pull request?

add StarRocks Catalog Implement

Why are the changes needed?

To support StarRocks Catalog.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By E2E test, the test is in another pr

#7792

@liunaijie liunaijie force-pushed the feature/catalog_sr2 branch from 5c5a7bd to 22c806b Compare July 28, 2025 05:23
@liunaijie liunaijie force-pushed the feature/catalog_sr2 branch from 55186af to 9d8fa51 Compare July 29, 2025 02:05
yuqi1129
yuqi1129 reviewed Jul 29, 2025
View reviewed changes
...ava/org/apache/gravitino/catalog/starrocks/operations/StarRocksTablePartitionOperations.java Outdated
RangePartition rangePartition = (RangePartition) partition;
partitionSqlFragment = StarRocksUtils.generatePartitionSqlFragment(rangePartition);

// The partition properties actually cannot be passed into Doris, we just return an empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doris -> StarRocks, also please check the same problem in L65 of StarRocksColumnDefaultValueConverter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liunaijie Good, do you have time to work on related documents? You can refer to the document at https://gravitino.apache.org/docs/0.9.1/jdbc-doris-catalog if you are willing to do it, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will add the document later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document commit: b54bfcc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document commit: b54bfcc

Where is the link to the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The E2E test and Document are in this pr https://github.com/apache/gravitino/pull/7792/commits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@yuqi1129 yuqi1129 requested a review from mchades July 29, 2025 06:33
yuqi1129
yuqi1129 reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It generally looks good to me except for a minor one.

yuqi1129
yuqi1129 approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 added the 1.0.0 Release v1.0.0 label Jul 30, 2025
@yuqi1129 yuqi1129 merged commit 8b4d86a into apache:main Jul 30, 2025
30 checks passed
jerqi pushed a commit to qqqttt123/gravitino that referenced this pull request Jul 30, 2025
@liunaijie @jerqi
[apache#3302][Sub-Task] StarRocks catalog Partition ops (apache#7791)
ac31c14 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

add StarRocks Catalog Implement

### Why are the changes needed?

To support StarRocks Catalog.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

By E2E test, the test is in another pr

apache#7792
tsungchih pushed a commit to tsungchih/gravitino that referenced this pull request Aug 2, 2025
@liunaijie @tsungchih
[apache#3302][Sub-Task] StarRocks catalog Partition ops (apache#7791)
730e814 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

add StarRocks Catalog Implement

### Why are the changes needed?

To support StarRocks Catalog.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

By E2E test, the test is in another pr

apache#7792
yuqi1129 pushed a commit to yuqi1129/gravitino that referenced this pull request Aug 15, 2025
@liunaijie @yuqi1129
[apache#3302][Sub-Task] StarRocks catalog Partition ops (apache#7791)
599f30c 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

add StarRocks Catalog Implement

### Why are the changes needed?

To support StarRocks Catalog.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

By E2E test, the test is in another pr

apache#7792
yuqi1129 pushed a commit to yuqi1129/gravitino that referenced this pull request Aug 18, 2025
@liunaijie @yuqi1129
[apache#3302][Sub-Task] StarRocks catalog Partition ops (apache#7791)
fedc289 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

add StarRocks Catalog Implement

### Why are the changes needed?

To support StarRocks Catalog.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

By E2E test, the test is in another pr

apache#7792
jerryshao pushed a commit that referenced this pull request Aug 18, 2025
@liunaijie @jerryshao
[#3302][Sub-Task] StarRocks catalog Partition ops (#7791)
8cdfda2 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

add StarRocks Catalog Implement

### Why are the changes needed?

To support StarRocks Catalog.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

By E2E test, the test is in another pr

#7792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi1129 yuqi1129 yuqi1129 approved these changes

@mchades mchades Awaiting requested review from mchades

Assignees

@liunaijie liunaijie

Labels
1.0.0 Release v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liunaijie @yuqi1129