[#5202] refactor(client-python): fix builder method of DTOs in expression #7582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#5202 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
|
@jerryshao @unknowntpo Could you please help with reviewing this PR when you are available? I would greatly appreciate any feedback from you. Thanks. |
|
@tsungchih I'll take a look later 👍 |
jerryshao
approved these changes
Jul 8, 2025
unknowntpo
reviewed
Jul 8, 2025
clients/client-python/gravitino/dto/rel/expressions/field_reference_dto.py
Show resolved
Hide resolved
|
@tsungchih LGTM, thanks for your contribution. |
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
…expression (apache#7582) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? This is a refactor of builder method for `LiteralDTO`, `FieldReferenceDTO`, `FuncExpressionDTO`, and `UnparsedExpressionDTO` that is proposed in the [comments](apache#7498 (review)) of the previous PR. ### Why are the changes needed? We need to support Column and its default value in python client. apache#5202 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests --------- Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
…expression (apache#7582) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? This is a refactor of builder method for `LiteralDTO`, `FieldReferenceDTO`, `FuncExpressionDTO`, and `UnparsedExpressionDTO` that is proposed in the [comments](apache#7498 (review)) of the previous PR. ### Why are the changes needed? We need to support Column and its default value in python client. apache#5202 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests --------- Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
jerqi
pushed a commit
to qqqttt123/gravitino
that referenced
this pull request
Jul 30, 2025
…expression (apache#7582) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? This is a refactor of builder method for `LiteralDTO`, `FieldReferenceDTO`, `FuncExpressionDTO`, and `UnparsedExpressionDTO` that is proposed in the [comments](apache#7498 (review)) of the previous PR. ### Why are the changes needed? We need to support Column and its default value in python client. apache#5202 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests --------- Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a refactor of builder method for
LiteralDTO,FieldReferenceDTO,FuncExpressionDTO, andUnparsedExpressionDTOthat is proposed in the comments of the previous PR.Why are the changes needed?
We need to support Column and its default value in python client.
#5202
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests