[#7521] fix(common): Fix precondition message mismatch #7525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @justinmclean |
yuqi1129
approved these changes
Jul 1, 2025
yuqi1129
approved these changes
Jul 1, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Update the error message in Preconditions.checkState to match the
validation logic.
This change ensures that the error message accurately reflects the
status being checked by the code.
### Why are the changes needed?
Previously, the validation logic allowed values greater than or equal to
-1, but the error message stated that only values greater than -1 were
acceptable. This could mislead users or developers.
Fix: #7521
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Local verification.
sdj3261
pushed a commit
to sdj3261/gravitino
that referenced
this pull request
Jul 7, 2025
…7525) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Update the error message in Preconditions.checkState to match the validation logic. This change ensures that the error message accurately reflects the status being checked by the code. ### Why are the changes needed? Previously, the validation logic allowed values greater than or equal to -1, but the error message stated that only values greater than -1 were acceptable. This could mislead users or developers. Fix: apache#7521 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Local verification.
jerryshao
pushed a commit
to jerryshao/gravitino
that referenced
this pull request
Jul 8, 2025
…7525) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Update the error message in Preconditions.checkState to match the validation logic. This change ensures that the error message accurately reflects the status being checked by the code. ### Why are the changes needed? Previously, the validation logic allowed values greater than or equal to -1, but the error message stated that only values greater than -1 were acceptable. This could mislead users or developers. Fix: apache#7521 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Local verification.
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
…7525) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Update the error message in Preconditions.checkState to match the validation logic. This change ensures that the error message accurately reflects the status being checked by the code. ### Why are the changes needed? Previously, the validation logic allowed values greater than or equal to -1, but the error message stated that only values greater than -1 were acceptable. This could mislead users or developers. Fix: apache#7521 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Local verification.
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
…7525) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Update the error message in Preconditions.checkState to match the validation logic. This change ensures that the error message accurately reflects the status being checked by the code. ### Why are the changes needed? Previously, the validation logic allowed values greater than or equal to -1, but the error message stated that only values greater than -1 were acceptable. This could mislead users or developers. Fix: apache#7521 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Local verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the error message in Preconditions.checkState to match the validation logic.
This change ensures that the error message accurately reflects the status being checked by the code.
Why are the changes needed?
Previously, the validation logic allowed values greater than or equal to -1, but the error message stated that only values greater than -1 were acceptable. This could mislead users or developers.
Fix: #7521
Does this PR introduce any user-facing change?
No
How was this patch tested?
Local verification.