[#5383] Add create table command to the Gravitino CLI #5717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
|
@justinmclean Is there a way to split this PR to smaller ones for ease of review and change management? A PR with 208 commits, 2800+ lines of change is too big to be reviewed effectively. |
|
Most of the commits are from other PRs that have been approved. There is no real easy way, as I could not rebase, given this was developed several months ago. The easiest way to review is to look at the files changed not the number of commits. |
|
Note there will be far less changes to review once the column PR is merged. |
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/DefaultConverter.java # clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestDefaultConverter.java
|
@shaofengshi this is ready for review. The failed CI is due to a network error and unrelated to the code changes. |
tengqm
reviewed
Dec 4, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTable.java
Show resolved
Hide resolved
|
lgtm. |
shaofengshi
reviewed
Dec 4, 2024
jerryshao
pushed a commit
that referenced
this pull request
Dec 6, 2024
### What changes were proposed in this pull request? Add the ability to create a table via the Gravitino CLI. ### Why are the changes needed? so we can create tables via the CLI. Fix: #5383 ### Does this PR introduce _any_ user-facing change? No, but it expands on CLI commands. ### How was this patch tested? Tested locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the ability to create a table via the Gravitino CLI.
Why are the changes needed?
so we can create tables via the CLI.
Fix: #5383
Does this PR introduce any user-facing change?
No, but it expands on CLI commands.
How was this patch tested?
Tested locally.