Skip to content

fix initialization problem when generateing wrapper object (#15276) #15288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix initialization problem when generateing wrapper object (#15276) #15288

merged 1 commit into from
Apr 7, 2025

Conversation

itaiit
Copy link
Contributor

@itaiit itaiit commented Apr 1, 2025

What is the purpose of the change?

fix initialization problem, add a call to the postProcessBeforeInitialization method when generateing wrapper object.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (c778473) to head (dd97b02).
Report is 70 commits behind head on 3.3.

Additional details and impacted files 
@@            Coverage Diff            @@
##                3.3   #15288   +/-   ##
=========================================
  Coverage     60.77%   60.77%           
+ Complexity    10920    10919    -1     
=========================================
  Files          1886     1886           
  Lines         86122    86123    +1     
  Branches      12902    12902           
=========================================
+ Hits          52337    52344    +7     
+ Misses        28331    28322    -9     
- Partials       5454     5457    +3
Flag Coverage Δ
integration-tests 33.19% <100.00%> (-0.01%) ⬇️
samples-tests 29.35% <100.00%> (+0.01%) ⬆️
unit-tests 58.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ AlbumenJ merged commit ab07a4b into apache:3.3 Apr 7, 2025
19 checks passed
guandk pushed a commit to guandk/dubbo that referenced this pull request Apr 13, 2025
@itaiit
fix initialization problem when generateing wrapper object (apache#15276
c59523a 
) (apache#15288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itaiit @codecov-commenter @AlbumenJ