CURATOR-667: Fix abnormal event config path from getConfig #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getConfig` will read data from path "/zookeeper/config" which belongs to no namespace nor chroot in ZooKeeper side. Path in background event or watch event should stick to "/zookeeper/config". See also: * https://issues.apache.org/jira/browse/ZOOKEEPER-4601 * https://lists.apache.org/thread/2tsg1hcopl80zot12tqrynrbg2h792jf
kezhuw
added a commit
to kezhuw/curator
that referenced
this pull request
Oct 16, 2024
CURATOR-667(apache#474) fixes asynchronous event path for `getConfig` to "/zookeeper/config" by using `CuratorFramework::usingNamespace(null)` to fetch data. It causes watcher not registering to possible `WatcherRemovalManager`, so leaking in `WatcherRemoveCuratorFramework::removeWatchers`.
kezhuw
added a commit
to kezhuw/curator
that referenced
this pull request
Oct 28, 2024
CURATOR-667(apache#474) fixes asynchronous event path for `getConfig` to "/zookeeper/config" by using `CuratorFramework::usingNamespace(null)` to fetch data. It causes watcher not registering to possible `WatcherRemovalManager`, so leaking in `WatcherRemoveCuratorFramework::removeWatchers`.
kezhuw
added a commit
to kezhuw/curator
that referenced
this pull request
Oct 28, 2024
CURATOR-667(apache#474) fixes asynchronous event path for `getConfig` to "/zookeeper/config" by using `CuratorFramework::usingNamespace(null)` to fetch data. It causes watcher not registering to possible `WatcherRemovalManager`, so leaking in `WatcherRemoveCuratorFramework::removeWatchers`.
kezhuw
added a commit
that referenced
this pull request
Jan 19, 2025
CURATOR-667(#474) fixes asynchronous event path for `getConfig` to "/zookeeper/config" by using `CuratorFramework::usingNamespace(null)` to fetch data. It causes watcher not registering to possible `WatcherRemovalManager`, so leaking in `WatcherRemoveCuratorFramework::removeWatchers`. Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: tison <wander4096@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getConfigwill read data from path "/zookeeper/config" which belongs to no namespace nor chroot in ZooKeeper side. Path in background event or watch event should stick to "/zookeeper/config".See also: