Skip to content

fix(style): centering rank text in the circle #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2022
Merged

fix(style): centering rank text in the circle #1628

merged 1 commit into from
Mar 12, 2022

Conversation

progfay
Copy link
Contributor

@progfay progfay commented Mar 3, 2022 •
edited
Loading

Description

It seems that the rank text of "GitHub Stats Card" is not centering.

Before

const circle = document.querySelector(".rank-circle").getBoundingClientRect()
const text = document.querySelector(".rank-text").getBoundingClientRect()

console.log(circle.x + circle.width / 2, circle.y + circle.height / 2) // => 390 110.5
console.log(text.x + text.width / 2, text.y + text.height / 2)         // => 391 107.5

After applying the changes

// at https://github-readme-stats.vercel.app/api?username=anuraghazra
const circle = document.querySelector(".rank-circle").getBoundingClientRect()
const text = document.querySelector(".rank-text").getBoundingClientRect()

console.log(circle.x + circle.width / 2, circle.y + circle.height / 2) // => 390 110.5
console.log(text.x + text.width / 2, text.y + text.height / 2)         // => 390 110.5

Compare

length 1 length 2 length 3
before length 1 (before) length 2 (before) length 3 (before)
after length 1 (after) length 2 (after) length 3 (after)

@vercel
Copy link

vercel bot commented Mar 3, 2022

@progfay is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@rickstaa rickstaa mentioned this pull request Mar 9, 2022
Closed
@rickstaa rickstaa linked an issue Mar 9, 2022 that may be closed by this pull request
Centre Text Inside Circle #1589
Closed
@jgphilpott
Copy link

I like it! 👌

@rickstaa
Copy link
Collaborator

rickstaa commented Mar 9, 2022

Great! We are in the middle of a big code cleanup but after that is done we will merge normal PR again.

@anuraghazra anuraghazra merged commit d7d0ba5 into anuraghazra:master Mar 12, 2022
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
@progfay @Kab1r
fix(style): centering rank text in the circle (anuraghazra#1628)
85d8bf8
@rickstaa rickstaa mentioned this pull request May 1, 2022
Merged
lencx pushed a commit to lencx/github-readme-stats that referenced this pull request May 16, 2022
@progfay @lencx
fix(style): centering rank text in the circle (anuraghazra#1628)
4f89035
necofuryai added a commit to necofuryai/github-readme-stats that referenced this pull request May 19, 2025
@necofuryai
fix(style): centering rank text in the circle (anuraghazra#1628)
769e799
xhayper pushed a commit to xhayper/github-readme-stats that referenced this pull request Jul 2, 2025
@progfay
fix(style): centering rank text in the circle (anuraghazra#1628)
09c8584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centre Text Inside Circle
4 participants
@progfay @jgphilpott @rickstaa @anuraghazra