Skip to content

feat: ConfigProvider support classNames and styles for Transfer #53429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 8, 2025
Merged

feat: ConfigProvider support classNames and styles for Transfer #53429

merged 14 commits into from
Apr 8, 2025

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 7, 2025 •
edited
Loading

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

标准 Semantic Structure，还有一些嵌套的之后再加：

  • classNames.selection: Dropdown
    • classNames.selection.title: Selection 本身的标题
  • classNames.search: Input.Search
  • classNames.pagination: Pagination

📝 Change Log

Language Changelog
🇺🇸 English Transfer support classNames and styles for semantic structure.
🇨🇳 Chinese Transfer 支持 classNames 与 styles 以定义语义化结构。

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

👁 Visual Regression Report for PR #53429 Passed ✅

🎯 Target branch: next (26e2f43)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 498.65 KB (+186 B 🔺)
dist/antd-with-locales.min.js 588.21 KB (+201 B 🔺)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 7, 2025 •
edited
Loading

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53429

commit: ec3429e

@codecov Codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.17kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.74MB 1.17kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js 583 bytes 2.06MB 0.03%
antd.min.js 583 bytes 1.68MB 0.03%

Files in antd-with-locales.min.js:

  • ./components/config-provider/context.ts → Total Size: 1.52kB

  • ./components/transfer/style/index.ts → Total Size: 8.61kB

Files in antd.min.js:

  • ./components/config-provider/context.ts → Total Size: 1.52kB

  • ./components/transfer/style/index.ts → Total Size: 8.61kB

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 7, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec3429e
Status: ✅  Deploy successful!
Preview URL: https://aa7f9ef1.ant-design.pages.dev
Branch Preview URL: https://transfer-sem.ant-design.pages.dev

View logs

thinkasany
thinkasany reviewed Apr 7, 2025
View reviewed changes
thinkasany
thinkasany reviewed Apr 7, 2025
View reviewed changes
thinkasany
thinkasany reviewed Apr 7, 2025
View reviewed changes
thinkasany
thinkasany reviewed Apr 7, 2025
View reviewed changes
thinkasany
thinkasany reviewed Apr 7, 2025
View reviewed changes
@thinkasany thinkasany mentioned this pull request Apr 7, 2025
Open
@thinkasany
Copy link
Member

title 看起来 不在 dropdown里面。
image

@zombieJ zombieJ mentioned this pull request Apr 8, 2025
Closed
17 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3102b8d) to head (ec3429e).
Report is 2 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #53429   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          780       780           
  Lines        14119     14122    +3     
  Branches      3721      3719    -2     
=========================================
+ Hits         14119     14122    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zombieJ zombieJ merged commit 0df532c into next Apr 8, 2025
44 checks passed
@zombieJ zombieJ deleted the transfer-sem branch April 8, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkasany thinkasany thinkasany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zombieJ @thinkasany