feat: ConfigProvider support classNames and styles for calendar #53159

thinkasany · 2025-03-14T07:05:38Z

🤔 This is a ...

🆕 New feature

📝 Change Log

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classNames and styles for calendar
🇨🇳 Chinese	feat: ConfigProvider support classNames and styles for calendar

bolt-new-by-stackblitz · 2025-03-14T07:05:40Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-03-14T07:05:48Z

github-actions · 2025-03-14T07:05:49Z

👁 Visual Regression Report for PR #53159 Passed ✅

🎯 Target branch: next (3796a7f)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

petercat-assistant · 2025-03-14T07:06:03Z

Walkthrough: This PR introduces support for classNames and styles in the ConfigProvider for the calendar component. It enables custom styling and class names for different parts of the calendar, enhancing flexibility and customization.

Changes:

Files	Summary
components/calendar/Header.tsx	Added `className` and `style` props to `CalendarHeader` and applied them using `classnames` and inline styles.
components/calendar/tests/index.test.tsx	Added tests to verify support for `classNames` and `styles`.
components/calendar/demo/_semantic.tsx	Added a demo showcasing semantic DOM elements with localized descriptions.
components/calendar/generateCalendar.tsx	Integrated `classNames` and `styles` into the calendar rendering logic, allowing for customizable styling.
components/calendar/index.en-US.md, components/calendar/index.zh-CN.md	Updated documentation to include semantic DOM information.
components/config-provider/context.ts	Updated `CalendarConfig` to include `classNames` and `styles`.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md	Updated documentation to reflect new `classNames` and `styles` support for the calendar.

components/calendar/__tests__/index.test.tsx

github-actions · 2025-03-14T07:08:21Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	507.68 KB (+378 B 🔺)
`dist/antd-with-locales.min.js`	598.96 KB (-795 B 🔽)

pkg-pr-new · 2025-03-14T07:09:12Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53159

commit: 13f151e

codecov · 2025-03-14T07:09:56Z

Bundle Report

Changes will decrease total bundle size by 952 bytes (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.9MB	-952 bytes (-0.02%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	-2.24kB	2.14MB	-0.1%
`antd.min.js`	1.29kB	1.76MB	0.07%

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

cloudflare-workers-and-pages · 2025-03-14T07:15:27Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`13f151e`
Status:	✅ Deploy successful!
Preview URL:	https://76bd6a1a.ant-design.pages.dev
Branch Preview URL:	https://cp-calendar.ant-design.pages.dev

View logs

codecov · 2025-03-14T07:29:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3796a7f) to head (13f151e).
Report is 1 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          778       778           
  Lines        14019     14022    +3     
  Branches      3676      3676           
=========================================
+ Hits         14019     14022    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai · 2025-03-19T07:18:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-03-19T09:12:42Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@rc-component/picker@1.0.1 ➜ 1.2.2	None	`0`	1.33 MB	zombiej
npm/cli-progress@3.12.0	None	`0`	62.2 kB	andidittrich
npm/cross-env@7.0.3	environment	`0`	29.1 kB	kentcdodds
npm/cross-fetch@4.1.0	network	`0`	93.3 kB	lquixada
npm/cypress-image-diff-html-report@2.2.0	filesystem	`0`	587 kB	kienht.dev
npm/dekko@0.2.1	filesystem	`0`	8.91 kB	benjycui
npm/dotenv@16.4.7	environment, filesystem	`0`	75.8 kB	motdotla
npm/dumi-plugin-color-chunk@1.1.2	None	`0`	38.7 kB	wxh16144
npm/dumi@2.4.18	environment, eval, filesystem	`0`	2.92 MB	yifankakaxi
npm/env-paths@3.0.0	None	`0`	9.81 kB	sindresorhus
npm/eslint-plugin-compat@6.0.2	filesystem	`+1`	202 kB	amilajack
npm/eslint-plugin-jest@28.11.0	None	`0`	350 kB	aaronabramov, jeysal, jsonp, ...6 more
npm/eslint-plugin-jsx-a11y@6.10.2	None	`0`	753 kB	ljharb
npm/eslint-plugin-react-hooks@5.2.0	None	`0`	278 kB	acdlite, brianvaughn, eps1lon, ...4 more
npm/eslint-plugin-react-refresh@0.4.19	None	`0`	18.2 kB	arnaud-barre
npm/eslint@9.22.0	None	`+1`	65.1 kB
npm/fast-glob@3.3.3	filesystem	`0`	98.4 kB	mrmlnc
npm/fs-extra@11.3.0	None	`0`	55.3 kB	ryanzim
npm/gh-pages@6.3.0	filesystem, shell	`0`	39.8 kB	tschaub
npm/glob@11.0.1	Transitive: environment	`+1`	913 kB	isaacs
npm/html2sketch@1.0.2	network	`0`	1.87 MB	arvinxx
npm/http-server@14.1.1	environment, filesystem, network	`0`	124 kB	thornjad
npm/husky@9.1.7	None	`0`	4.04 kB	typicode
npm/identity-obj-proxy@3.0.0	None	`0`	8.38 kB	keyanzhang
npm/immer@10.1.1	environment	`0`	627 kB	mweststrate
npm/is-ci@4.1.0	None	`+1`	33.3 kB	sibiraj-s
npm/isomorphic-fetch@3.0.0	Transitive: network	`+1`	169 kB	mattandrews
npm/jest-axe@10.0.0	None	`0`	21 kB	nickcolley
npm/jest-canvas-mock@2.5.2	None	`0`	112 kB	atool
npm/jest@29.7.0	None	`0`	5.01 kB	simenb

View full report↗︎

zombieJ · 2025-03-20T07:19:31Z

components/calendar/demo/_semantic.tsx

+    header: '头部元素',
+    body: '主体元素',
+    content: '内容元素',
+    item: '条目元素',


上提到 td 里：

需要来个patch，把 item 提升到 td 的 cell classname 上

https://github.com/react-component/picker/pull/924/files

petercat-assistant bot reviewed Mar 14, 2025

View reviewed changes

components/calendar/__tests__/index.test.tsx Outdated Show resolved Hide resolved

thinkasany mentioned this pull request Mar 14, 2025

Ant Design v6 tasks #52115

Open

thinkasany force-pushed the cp-calendar branch from d603836 to 73e69b2 Compare March 19, 2025 07:18

thinkasany force-pushed the cp-calendar branch from 73e69b2 to 229138c Compare March 19, 2025 07:21

thinkasany force-pushed the cp-calendar branch 2 times, most recently from e097763 to bedf7b4 Compare March 20, 2025 03:43

zombieJ reviewed Mar 20, 2025

View reviewed changes

thinkasany force-pushed the cp-calendar branch from bedf7b4 to cbc78f5 Compare March 21, 2025 08:09

thinkasany added 2 commits March 21, 2025 16:09

feat: ConfigProvider support classNames and styles for calendar

a04c573

fix

3a0d9f7

thinkasany force-pushed the cp-calendar branch from cbc78f5 to 3a0d9f7 Compare March 21, 2025 08:09

fix

13f151e

zombieJ approved these changes Mar 21, 2025

View reviewed changes

zombieJ merged commit 84883ac into next Mar 21, 2025
44 checks passed

zombieJ deleted the cp-calendar branch March 21, 2025 09:38

Uh oh!

feat: ConfigProvider support classNames and styles for calendar #53159

feat: ConfigProvider support classNames and styles for calendar #53159

Uh oh!

Conversation

thinkasany commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53159 Passed ✅

Uh oh!

petercat-assistant bot commented Mar 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

cloudflare-workers-and-pages bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Mar 19, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

socket-security bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zombieJ Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

thinkasany Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thinkasany commented Mar 14, 2025 •

edited

Loading

github-actions bot commented Mar 14, 2025 •

edited

Loading

github-actions bot commented Mar 14, 2025 •

edited

Loading

github-actions bot commented Mar 14, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 14, 2025 •

edited

Loading

codecov bot commented Mar 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 14, 2025 •

edited

Loading

codecov bot commented Mar 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Mar 19, 2025 •

edited

Loading