feat: ConfigProvider support classNames and styles for image #53028

thinkasany · 2025-03-03T09:13:36Z

🤔 This is a ...

🆕 New feature

🔗 Related Issues

📝 Change Log

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classNames and styles for image
🇨🇳 Chinese	feat: ConfigProvider support classNames and styles for image

bolt-new-by-stackblitz · 2025-03-03T09:13:39Z

Run & review this pull request in StackBlitz Codeflow.

accesslint

There are accessibility issues in these changes.

components/image/demo/_semantic.tsx

github-actions · 2025-03-03T09:13:47Z

👁 Visual Regression Report for PR #53028 Passed ✅

🎯 Target branch: next (f0ed87f)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

github-actions · 2025-03-03T09:13:47Z

petercat-assistant · 2025-03-03T09:13:55Z

Walkthrough

This PR introduces a new feature to the ConfigProvider, adding support for classNames and styles for images. This enhancement allows for more customizable styling options for image components, particularly in preview configurations.

Changes

Files	Summary
components/config-provider/context.ts	Added `classNames` and `styles` to `ImageConfig` interface for image preview customization.
components/image/demo/_semantic.tsx	Added a new demo file showcasing semantic DOM usage with image previews.
components/image/index.en-US.md, components/image/index.zh-CN.md	Updated documentation to include semantic DOM example.
components/image/index.tsx	Enhanced image preview functionality to support `classNames` and `styles` from context.

components/image/demo/_semantic.tsx

github-actions · 2025-03-03T09:16:31Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	506.75 KB (-367 B 🔽)
`dist/antd-with-locales.min.js`	599.24 KB (-600 B 🔽)

cloudflare-workers-and-pages · 2025-03-03T09:21:33Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`b2e1c25`
Status:	✅ Deploy successful!
Preview URL:	https://8ce8076d.ant-design.pages.dev
Branch Preview URL:	https://cp-image.ant-design.pages.dev

View logs

codecov · 2025-03-05T08:08:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (55e075f) to head (b2e1c25).
Report is 13 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53028   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          773       778    +5     
  Lines        13929     13999   +70     
  Branches      3652      3672   +20     
=========================================
+ Hits         13929     13999   +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

accesslint

There are accessibility issues in these changes.

components/image/__tests__/index.test.tsx

socket-security · 2025-03-05T09:17:01Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@rc-component/image@1.0.0 ➜ 1.2.5	None	`0`	135 kB	zombiej

View full report↗︎

accesslint

There are accessibility issues in these changes.

components/image/__tests__/index.test.tsx

pkg-pr-new · 2025-03-05T09:18:49Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53028

commit: b2e1c25

accesslint

There are accessibility issues in these changes.

components/image/__tests__/index.test.tsx

codecov · 2025-03-05T09:24:27Z

Bundle Report

Changes will increase total bundle size by 2.27kB (0.06%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.9MB	2.27kB (0.06%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	1.15kB	2.14MB	0.05%
`antd.min.js`	1.12kB	1.76MB	0.06%

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB
./components/image/style/index.ts → Total Size: 8.33kB

Files in antd.min.js:

./components/image/style/index.ts → Total Size: 8.33kB
./components/config-provider/context.ts → Total Size: 1.51kB

components/image/demo/_semantic.tsx

accesslint

There are accessibility issues in these changes.

components/image/__tests__/index.test.tsx

components/image/demo/_semantic.tsx

accesslint

There are accessibility issues in these changes.

components/image/demo/_semantic.tsx

components/image/demo/_semanticPreview.tsx

accesslint

There are accessibility issues in these changes.

components/image/__tests__/__snapshots__/index.test.tsx.snap

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/__tests__/index.test.tsx

components/image/demo/_semantic.tsx

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

accesslint

There are accessibility issues in these changes.

components/image/__tests__/index.test.tsx

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

components/image/__tests__/__snapshots__/index.test.tsx.snap

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/__tests__/__snapshots__/demo-extend.test.ts.snap

components/image/__tests__/__snapshots__/demo.test.ts.snap

components/image/index.tsx

.dumi/components/SemanticPreview.tsx

components/image/index.zh-CN.md

components/image/index.tsx

accesslint

There are accessibility issues in these changes.

components/image/__tests__/deprecated.test.tsx

accesslint

There are accessibility issues in these changes.

components/image/__tests__/deprecated.test.tsx

accesslint

There are accessibility issues in these changes.

components/image/__tests__/deprecated.test.tsx

accesslint

There are accessibility issues in these changes.

components/image/__tests__/deprecated.test.tsx

thinkasany · 2025-03-19T02:48:10Z

LGTM

accesslint bot reviewed Mar 3, 2025

View reviewed changes

components/image/demo/_semantic.tsx Outdated Show resolved Hide resolved

petercat-assistant bot reviewed Mar 3, 2025

View reviewed changes

components/image/demo/_semantic.tsx Outdated Show resolved Hide resolved

thinkasany mentioned this pull request Mar 3, 2025

Ant Design v6 tasks #52115

Open

thinkasany force-pushed the cp-image branch from 02b552f to 43722c6 Compare March 5, 2025 07:47

accesslint bot reviewed Mar 5, 2025

View reviewed changes

components/image/__tests__/index.test.tsx Show resolved Hide resolved

thinkasany force-pushed the cp-image branch from 8e15592 to c4d0251 Compare March 5, 2025 09:17

accesslint bot reviewed Mar 5, 2025

View reviewed changes

components/image/__tests__/index.test.tsx Show resolved Hide resolved

thinkasany force-pushed the cp-image branch from c4d0251 to a915b50 Compare March 5, 2025 09:19

accesslint bot reviewed Mar 5, 2025

View reviewed changes

components/image/__tests__/index.test.tsx Show resolved Hide resolved

zombieJ reviewed Mar 5, 2025

View reviewed changes

components/image/demo/_semantic.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Mar 5, 2025

View reviewed changes

components/image/demo/_semantic.tsx Outdated Show resolved Hide resolved

accesslint bot reviewed Mar 5, 2025

View reviewed changes

components/image/__tests__/index.test.tsx Show resolved Hide resolved

components/image/demo/_semantic.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Mar 6, 2025

View reviewed changes

components/image/demo/_semantic.tsx Show resolved Hide resolved

thinkasany force-pushed the cp-image branch 3 times, most recently from 4c09ef1 to 9788053 Compare March 10, 2025 03:49

accesslint bot reviewed Mar 11, 2025

View reviewed changes

components/image/demo/_semantic.tsx Outdated Show resolved Hide resolved

components/image/demo/_semanticPreview.tsx Outdated Show resolved Hide resolved

accesslint bot reviewed Mar 11, 2025

View reviewed changes

thinkasany force-pushed the cp-image branch from ad21e6f to 98ff254 Compare March 11, 2025 15:10

zombieJ added 8 commits March 18, 2025 14:12

chore: update demo

151c9d6

chore: bump rc-image

c6ea7d3

chore: bump rc-image

c5dfadb

docs: fix demo

3616cd1

chore: clean up

3bc0d89

chore: unique code

f8a354c

chore: fix lint

3f94dd5

chore: bump rc-image

dd9addd

thinkasany commented Mar 18, 2025

View reviewed changes

components/image/index.tsx Outdated Show resolved Hide resolved

thinkasany commented Mar 18, 2025

View reviewed changes

.dumi/components/SemanticPreview.tsx Show resolved Hide resolved

thinkasany commented Mar 18, 2025

View reviewed changes

components/image/index.zh-CN.md Show resolved Hide resolved

thinkasany commented Mar 18, 2025

View reviewed changes

components/image/index.tsx Outdated Show resolved Hide resolved

test: add deprecated warning

24192ea

accesslint bot reviewed Mar 18, 2025

View reviewed changes

zombieJ added 3 commits March 18, 2025 20:02

docs: update docs

291ea4b

docs: order api

c0c5b9d

docs: update docs

e19a1c5

accesslint bot reviewed Mar 18, 2025

View reviewed changes

zombieJ added 5 commits March 18, 2025 22:02

docs: update docs

0a015bb

docs: update docs

212a9a0

docs: update docs

bcaa33b

chore: clean up

c682187

chore: translate

763c038

accesslint bot reviewed Mar 18, 2025

View reviewed changes

docs: fix logic

b2e1c25

accesslint bot reviewed Mar 18, 2025

View reviewed changes

zombieJ approved these changes Mar 19, 2025

View reviewed changes

zombieJ merged commit 23b8710 into next Mar 19, 2025
42 checks passed

zombieJ deleted the cp-image branch March 19, 2025 02:53

Uh oh!

feat: ConfigProvider support classNames and styles for image #53028

feat: ConfigProvider support classNames and styles for image #53028

Uh oh!

Conversation

thinkasany commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Mar 3, 2025

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53028 Passed ✅

Uh oh!

github-actions bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant bot commented Mar 3, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

cloudflare-workers-and-pages bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

socket-security bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

Uh oh!

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

thinkasany commented Mar 3, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 3, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

socket-security bot commented Mar 5, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading