Skip to content

feat: ConfigProvider support classnames and styles for timeline #52976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat: ConfigProvider support classnames and styles for timeline #52976

merged 1 commit into from
Feb 28, 2025

Conversation

thinkasany
Copy link
Member

🤔 This is a ...

  • 🆕 New feature

📝 Change Log

Language Changelog
🇺🇸 English feat: ConfigProvider support classnames and styles for timeline
🇨🇳 Chinese feat: ConfigProvider support classnames and styles for timeline

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

👁 Visual Regression Report for PR #52976 Passed ✅

🎯 Target branch: next (4c769f1)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@thinkasany thinkasany mentioned this pull request Feb 26, 2025
Open
@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request introduces a new feature that enhances the ConfigProvider by adding support for classnames and styles specifically for the timeline component. This change allows for more customizable styling options for timelines within the Ant Design framework.

Changes

Files Summary
components/config-provider/context.ts Added TimelineProps and TimelineConfig to support classNames and styles for timeline.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md Updated documentation to reflect new timeline properties.
components/timeline/Timeline.tsx, components/timeline/TimelineItem.tsx, components/timeline/TimelineItemList.tsx Modified components to utilize new classNames and styles properties.
components/timeline/tests/index.test.tsx Added tests for the new classNames and styles support.
components/timeline/demo/_semantic.tsx Added a demo for semantic DOM usage.
components/timeline/index.en-US.md, components/timeline/index.zh-CN.md Updated documentation to include semantic DOM section.

petercat-assistant[bot]
petercat-assistant bot reviewed Feb 26, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 505.32 KB (+241 B 🔺)
dist/antd-with-locales.min.js 597.03 KB (+236 B 🔺)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 26, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52976

commit: e881ec2

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 7.79MB (200.28%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 11.68MB 7.79MB (200.28%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js (New) 6.14MB 6.14MB 100.0% 🚀
antd.js (New) 5.54MB 5.54MB 100.0% 🚀
antd-with-locales.min.js (Deleted) -2.13MB 0 bytes -100.0% 🗑️
antd.min.js (Deleted) -1.75MB 0 bytes -100.0% 🗑️

Files in antd-with-locales.js:

  • ./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.js:

  • ./components/config-provider/context.ts → Total Size: 1.51kB

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: e881ec2
Status: ✅  Deploy successful!
Preview URL: https://d2861c81.ant-design.pages.dev
Branch Preview URL: https://cp-timeline.ant-design.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4c769f1) to head (e881ec2).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52976   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          766       766           
  Lines        13773     13774    +1     
  Branches      3614      3615    +1     
=========================================
+ Hits         13773     13774    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit ab4f326 into next Feb 28, 2025
42 checks passed
@zombieJ zombieJ deleted the cp-timeline branch February 28, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @zombieJ