Skip to content

feat: ConfigProvider support classnames and styles for select #52948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2025
Merged

feat: ConfigProvider support classnames and styles for select #52948

merged 3 commits into from
Mar 13, 2025

Conversation

thinkasany
Copy link
Member

🤔 This is a ...

  • 🆕 New feature

🔗 Related Issues

wait for react-component/select#1128

📝 Change Log

Language Changelog
🇺🇸 English feat: ConfigProvider support classnames and styles for select
🇨🇳 Chinese feat: ConfigProvider support classnames and styles for select

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

accesslint[bot]
accesslint bot reviewed Feb 25, 2025
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

👁 Visual Regression Report for PR #52948 Passed ✅

🎯 Target branch: next (ec3b479)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request introduces a new feature that enhances the ConfigProvider to support classnames and styles for the Select component. This allows for more flexible styling and customization of the select component's appearance.

Changes

Files Summary
components/config-provider/context.ts Updated SelectConfig to include classnames and styles from SelectProps.
components/select/demo/_semantic.tsx Added a new demo file showcasing the semantic DOM structure for the Select component.
components/select/index.en-US.md, components/select/index.zh-CN.md Updated documentation to include information about the semantic DOM.
components/select/index.tsx Enhanced SelectProps to support classnames and styles, added deprecation warnings for certain props, and updated the component to merge styles and classnames from context and props.

petercat-assistant[bot]
petercat-assistant bot reviewed Feb 25, 2025
View reviewed changes
components/select/index.tsx
['popupClassName', 'classNames: {{ popup: ""}}'],
['dropdownStyle', '{{ popup: {}}}'],
].forEach(([deprecatedName, newName]) => {
warning.deprecated(!(deprecatedName in props), deprecatedName, newName);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation warning logic is implemented correctly, but ensure that the warning message is clear and provides guidance on how to transition to the new API. This is crucial for developers to adapt their code without confusion.

@thinkasany thinkasany mentioned this pull request Feb 25, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 505.61 KB (+308 B 🔺)
dist/antd-with-locales.min.js 599.24 KB (+394 B 🔺)

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 25, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26164a9
Status: ✅  Deploy successful!
Preview URL: https://410aa7fb.ant-design.pages.dev
Branch Preview URL: https://cp-select.ant-design.pages.dev

View logs

@thinkasany thinkasany force-pushed the cp-select branch 2 times, most recently from 92597fc to 3dbd0e2 Compare February 28, 2025 10:43
accesslint[bot]
accesslint bot reviewed Mar 12, 2025
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@thinkasany thinkasany force-pushed the cp-select branch 2 times, most recently from accf0f7 to e2e4c1e Compare March 13, 2025 07:34
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 13, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52948

commit: 26164a9

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 7.78MB (-66.61%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.9MB -7.78MB (-66.61%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js (New) 2.14MB 2.14MB 100.0% 🚀
antd.min.js (New) 1.76MB 1.76MB 100.0% 🚀
antd-with-locales.js (Deleted) -6.14MB 0 bytes -100.0% 🗑️
antd.js (Deleted) -5.54MB 0 bytes -100.0% 🗑️

Files in antd-with-locales.min.js:

  • ./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.min.js:

  • ./components/config-provider/context.ts → Total Size: 1.51kB

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ec3b479) to head (26164a9).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          773       773           
  Lines        13921     13929    +8     
  Branches      3650      3652    +2     
=========================================
+ Hits         13921     13929    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zombieJ zombieJ merged commit 55e075f into next Mar 13, 2025
42 checks passed
@zombieJ zombieJ deleted the cp-select branch March 13, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

+2 more reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @zombieJ