feat: ConfigProvider support classnames and styles for notification #52759

thinkasany · 2025-02-12T03:45:46Z

🤔 This is a ...

🆕 New feature

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classnames and styles for notification
🇨🇳 Chinese	feat: ConfigProvider support classnames and styles for notification

bolt-new-by-stackblitz · 2025-02-12T03:45:49Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-02-12T03:45:57Z

👁 Visual Regression Report for PR #52759 Failed ❌

🎯 Target branch: next (aaf384a)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 2 changed

Expected (Branch next)	Actual (Current PR)	Diff
input-group.compact.png	input-group.compact.css-var.png
input-otp.compact.png	input-otp.compact.css-var.png

Important

There are 2 diffs found in this PR: 🔄 2 changed.
Please check all items:

Visual diff is acceptable

github-actions · 2025-02-12T03:45:58Z

petercat-assistant · 2025-02-12T03:46:08Z

Walkthrough: This pull request introduces a new feature to the ConfigProvider, allowing support for classnames and styles customization for notifications. The changes involve replacing the message property with title in notifications and adding support for classNames and styles properties.

Changes:

Files	Summary
components/notification/*	Replaced `message` with `title` in notification components and added `classNames` and `styles` support.
components/config-provider/context.ts	Updated `NotificationConfig` to include `classNames` and `styles`.
components/notification/interface.ts	Deprecated `message` in favor of `title` and added `classNames` and `styles`.
components/notification/style/index.ts	Updated styles to reflect the change from `message` to `title`.
components/notification/useNotification.tsx	Integrated `classNames` and `styles` into notification handling.
components/notification/PurePanel.tsx	Enhanced `PurePanel` to support `classNames` and `styles`.
components/notification/demo/*	Updated demo files to use `title` instead of `message`.
components/notification/tests/*	Adjusted tests to reflect the changes from `message` to `title`.

petercat-assistant · 2025-02-12T03:46:10Z

components/notification/PurePanel.tsx

@@ -34,13 +34,17 @@ export function getCloseIcon(prefixCls: string, closeIcon?: React.ReactNode): Re
 export interface PureContentProps {
  prefixCls: string;
  icon?: React.ReactNode;
+  /** @deprecated Please use `title` instead */


The message property is deprecated, and title should be used instead. Ensure that all instances of message are replaced with title to maintain consistency and avoid deprecated warnings.

github-actions · 2025-02-12T03:48:27Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	503.33 KB (+394 B 🔺)
`dist/antd-with-locales.min.js`	572.33 KB (+361 B 🔺)

pkg-pr-new · 2025-02-12T03:49:15Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52759

commit: 088f36d

codecov · 2025-02-12T03:50:03Z

Bundle Report

Changes will increase total bundle size by 7.92MB (212.09%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
antd.min-array-push	11.65MB	7.92MB (212.09%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js` (New)	6.08MB	6.08MB	100.0% 🚀
`antd.js` (New)	5.57MB	5.57MB	100.0% 🚀
~~`antd-with-locales.min.js`~~ (Deleted)	-2.02MB	0 bytes	-100.0% 🗑️
~~`antd.min.js`~~ (Deleted)	-1.71MB	0 bytes	-100.0% 🗑️

Files in antd-with-locales.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.js:

./components/config-provider/context.ts → Total Size: 1.51kB

cloudflare-workers-and-pages · 2025-02-12T03:54:15Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`088f36d`
Status:	✅ Deploy successful!
Preview URL:	https://9c0ac8bf.ant-design.pages.dev
Branch Preview URL:	https://cp-notifaction.ant-design.pages.dev

View logs

codecov · 2025-02-12T04:01:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e6d4eb0) to head (088f36d).
Report is 4 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #52759   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          765       765           
  Lines        13769     13781   +12     
  Branches      3601      3608    +7     
=========================================
+ Hits         13769     13781   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/notification/__tests__/index.test.tsx

thinkasany added 5 commits February 12, 2025 11:43

feat: notification support classnames

0d94cab

update message to title

3abbe3c

add test

b1451bc

remove content

47b4614

fix

3cc56aa

petercat-assistant bot reviewed Feb 12, 2025

View reviewed changes

thinkasany mentioned this pull request Feb 12, 2025

Ant Design v6 tasks #52115

Open

zombieJ reviewed Feb 12, 2025

View reviewed changes

components/notification/__tests__/index.test.tsx Show resolved Hide resolved

thinkasany added 2 commits February 12, 2025 14:55

add message API compatibility test

64c4b10

skip ts check

137be8a

zombieJ reviewed Feb 12, 2025

View reviewed changes

components/notification/__tests__/index.test.tsx Show resolved Hide resolved

warning errspy

acbcb33

zombieJ reviewed Feb 12, 2025

View reviewed changes

components/notification/__tests__/index.test.tsx Show resolved Hide resolved

errSpy.mockRestore();

088f36d

zombieJ approved these changes Feb 13, 2025

View reviewed changes

zombieJ merged commit 2a7f2e0 into next Feb 13, 2025
42 checks passed

zombieJ deleted the cp-notifaction branch February 13, 2025 03:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: ConfigProvider support classnames and styles for notification #52759

feat: ConfigProvider support classnames and styles for notification #52759

Uh oh!

thinkasany commented Feb 12, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025 •

edited by thinkasany

Loading

Uh oh!

github-actions bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

petercat-assistant bot commented Feb 12, 2025

Uh oh!

petercat-assistant bot Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 12, 2025 •

edited

Loading

Assets Changed:

Uh oh!

cloudflare-workers-and-pages bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: ConfigProvider support classnames and styles for notification #52759

feat: ConfigProvider support classnames and styles for notification #52759

Uh oh!

Conversation

thinkasany commented Feb 12, 2025

🤔 This is a ...

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025 • edited by thinkasany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #52759 Failed ❌

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant bot commented Feb 12, 2025

Uh oh!

petercat-assistant bot Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

cloudflare-workers-and-pages bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2025 •

edited by thinkasany

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading