feat: ConfigProvider support classnames and styles for Alert #52669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #52669 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 131 diffs found in this PR: 🔄
|
|
components/alert/Alert.tsx
Outdated
| @@ -20,6 +20,7 @@ export interface AlertRef { | |||
| nativeElement: HTMLDivElement; | |||
| } | |||
|
|
|||
| type SemanticName = 'root' | 'icon' | 'content' | 'message' | 'description' | 'action'; | |||
There was a problem hiding this comment.
The introduction of SemanticName type is a good addition for better type safety and clarity when dealing with class names and styles.
size-limit report 📦
|
Bundle ReportChanges will increase total bundle size by 7.88MB (211.36%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
Deploying ant-design with
|
| Latest commit: |
2748468
|
| Status: | ⚡️ Build in progress... |
More templates
commit: |
zombieJ
approved these changes
Feb 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52669 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 765 765
Lines 13738 13745 +7
Branches 3578 3583 +5
=========================================
+ Hits 13738 13745 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
📝 Change Log