Skip to content

Conversation

kiner-tang
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for tree-select
🇨🇳 Chinese tree-select 废弃 api 退休

@kiner-tang kiner-tang requested review from zombieJ and MadCcc January 18, 2025 11:38
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 18, 2025

Preview is ready

Copy link
Contributor

github-actions bot commented Jan 18, 2025

👁 Visual Regression Report for PR #52471 Failed ❌

🎯 Target branch: next (c4ea4db)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

Copy link

Walkthrough

This pull request introduces a new feature by retiring deprecated APIs for the tree-select component. The changes involve removing the dropdownClassName property and its associated warnings, encouraging the use of popupClassName instead.

Changes

Files Summary
components/tree-select/tests/index.test.tsx Removed test case for deprecated dropdownClassName property.
components/tree-select/index.tsx Removed dropdownClassName property and related warnings, updated logic to use popupClassName.

Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 497.46 KB (-14 B 🔽)
dist/antd-with-locales.min.js 565.92 KB (-15 B 🔽)

Copy link

pkg-pr-new bot commented Jan 18, 2025

Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae74c29
Status: ✅  Deploy successful!
Preview URL: https://83260d4e.ant-design.pages.dev
Branch Preview URL: https://v6-kiner-retire-deprecated-a-rxpn.ant-design.pages.dev

View logs

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c4ea4db) to head (ae74c29).
Report is 37 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #52471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13677     13675    -2     
  Branches      3575      3574    -1     
=========================================
- Hits         13677     13675    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -60,8 +60,6 @@ export interface TreeSelectProps<ValueType = any, OptionType extends DataNode =
disabled?: boolean;
placement?: SelectCommonPlacement;
popupClassName?: string;
/** @deprecated Please use `popupClassName` instead */
dropdownClassName?: string;
/** @deprecated Use `variant` instead. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderd 还要支持一段时间么
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面好像还有几个要删除的
image

@zombieJ zombieJ merged commit a166cb3 into next Jan 22, 2025
46 checks passed
@zombieJ zombieJ deleted the v6-kiner-retire-deprecated-api-tree-select branch January 22, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants