Skip to content

feat: [V6] Retire deprecated api for tooltip/popover/popconfirm #52457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat: [V6] Retire deprecated api for tooltip/popover/popconfirm #52457

merged 1 commit into from
Jan 17, 2025

Conversation

thinkasany
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for tooltip/popover/popconfirm
🇨🇳 Chinese tooltip/popover/popconfirm废弃 api 退休

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited by thinkasany
Loading

👁 Visual Regression Report for PR #52457 Failed ❌

🎯 Target branch: next (0b6d56c)
📖 View Full Report ↗︎
📊 Summary: 🔄 72 changed

Expected (Branch next) Actual (Current PR) Diff
checkbox-debug-line.compact.png checkbox-debug-line.compact.png checkbox-debug-line.compact.png checkbox-debug-line.compact.png
checkbox-debug-line.compact.png checkbox-debug-line.compact.png checkbox-debug-line.compact.css-var.png checkbox-debug-line.compact.css-var.png
checkbox-debug-line.dark.png checkbox-debug-line.dark.png checkbox-debug-line.dark.png checkbox-debug-line.dark.png
checkbox-debug-line.dark.png checkbox-debug-line.dark.png checkbox-debug-line.dark.css-var.png checkbox-debug-line.dark.css-var.png
checkbox-debug-line.default.png checkbox-debug-line.default.png checkbox-debug-line.default.png checkbox-debug-line.default.png
checkbox-debug-line.default.png checkbox-debug-line.default.png checkbox-debug-line.default.css-var.png checkbox-debug-line.default.css-var.png
drawer-extra.compact.png drawer-extra.compact.png drawer-extra.compact.png drawer-extra.compact.png
drawer-extra.compact.png drawer-extra.compact.png drawer-extra.compact.css-var.png drawer-extra.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 72 diffs found in this PR: 🔄 72 changed.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Preview is ready

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request focuses on retiring deprecated APIs for tooltip, popover, and popconfirm components in the Ant Design library. The changes involve removing deprecated properties and methods, updating tests, and ensuring that the components use the new API conventions.

Changes

Files Summary
components/popconfirm/tests/index.test.tsx Removed tests related to deprecated visible and onVisibleChange properties.
components/popconfirm/index.tsx Removed deprecated visible and onVisibleChange properties from the Popconfirm component.
components/popover/index.tsx Removed deprecated visible and defaultVisible properties from the Popover component.
components/tooltip/tests/tooltip.test.tsx Removed tests related to deprecated properties and warnings for Tooltip.
components/tooltip/index.tsx Removed deprecated properties and methods, updated to use new API conventions for Tooltip.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 17, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52457

commit: 9d47ae2

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

Bundle Report

Changes will increase total bundle size by 7.88MB (211.34%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 11.6MB 7.88MB (211.34%) ⬆️⚠️

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c0286f1) to head (9d47ae2).
Report is 45 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13695     13677   -18     
  Branches      3585      3575   -10     
=========================================
- Hits         13695     13677   -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit c4ea4db into ant-design:next Jan 17, 2025
40 checks passed
@kiner-tang kiner-tang mentioned this pull request Jan 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @zombieJ