Skip to content

feat: ConfigProvider support classnames and styles for segmented #52376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat: ConfigProvider support classnames and styles for segmented #52376

merged 2 commits into from
Jan 16, 2025

Conversation

thinkasany
Copy link
Member

🤔 This is a ...

  • 🆕 New feature

🔗 Related Issues

react-component/segmented#296

📝 Change Log

Language Changelog
🇺🇸 English 🆕 ConfigProvider support segmented semantic props classNames and styles.
🇨🇳 Chinese 🆕 ConfigProvider 支持 segmented组件语义化 classNames 和 styles。

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited by zombieJ
Loading

👁 Visual Regression Report for PR #52376 Failed ❌

🎯 Target branch: next (50da162)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Preview is ready

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request introduces a new feature to the ConfigProvider component, adding support for segmented semantic properties classNames and styles. This enhancement allows developers to apply custom class names and styles to segmented components, improving customization and styling flexibility.

Changes

Files Summary
components/config-provider/context.ts Added SegmentedConfig type to support classNames and styles for segmented components.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md Updated documentation to reflect new segmented properties classNames and styles.
components/segmented/tests/index.test.tsx Added tests to verify custom styles and class names for segmented components.
components/segmented/demo/_semantic.tsx Added a new demo file to showcase semantic DOM usage with segmented components.
components/segmented/index.en-US.md, components/segmented/index.zh-CN.md Updated documentation to include semantic DOM information.
components/segmented/index.tsx Implemented support for classNames and styles in segmented components.

petercat-assistant[bot]
petercat-assistant bot reviewed Jan 13, 2025
View reviewed changes
components/segmented/index.tsx
}}
>
{icon}
</span>
{label && <span>{label}</span>}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the label span also supports custom classNames and styles similar to the icon span to maintain consistency in customization options.

@thinkasany thinkasany mentioned this pull request Jan 13, 2025
Open
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint-plugin-jest@28.11.0 None 0 350 kB aaronabramov, jeysal, jsonp, ...6 more

🚮 Removed packages: npm/rc-segmented@2.7.0

View full report↗︎

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 16, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52376

commit: c8afe6d

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 606 bytes (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.39MB 606 bytes (-0.02%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (50da162) to head (c8afe6d).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52376   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13695     13695           
  Branches      3584      3584           
=========================================
  Hits         13695     13695

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 0b6d56c into ant-design:next Jan 16, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @zombieJ