Skip to content

feat: [v6] Retire deprecated api for slider #52369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat: [v6] Retire deprecated api for slider #52369

merged 2 commits into from
Jan 13, 2025

Conversation

kiner-tang
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for slider
🇨🇳 Chinese slider 废弃 api 退休

@kiner-tang kiner-tang requested review from zombieJ and MadCcc January 12, 2025 05:43
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited by kiner-tang
Loading

👁 Visual Regression Report for PR #52369 Failed ❌

🎯 Target branch: next (07c34d9)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

Preview is ready

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request removes deprecated API elements from the Slider component in the Ant Design library. It eliminates deprecated properties and their associated logic, including tests for deprecated warnings, to streamline the component's codebase.

Changes

File Summary
components/slider/tests/index.test.tsx Removed tests related to deprecated API warnings for the Slider component.
components/slider/index.tsx Removed deprecated properties and their usage from the Slider component, including tooltipPrefixCls, tipFormatter, tooltipVisible, getTooltipPopupContainer, and tooltipPlacement.

@kiner-tang kiner-tang mentioned this pull request Jan 12, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 445.25 KB (-75 B 🔽)
dist/antd-with-locales.min.js 513.44 KB (-93 B 🔽)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 12, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52369

commit: f0d1bdf

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0d1bdf
Status: ✅  Deploy successful!
Preview URL: https://e4498832.ant-design.pages.dev
Branch Preview URL: https://v6-kiner-retire-deprecated-a-fh58.ant-design.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (07c34d9) to head (f0d1bdf).
Report is 17 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13699     13693    -6     
  Branches      3581      3575    -6     
=========================================
- Hits         13699     13693    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025

Bundle Report

Changes will decrease total bundle size by 506 bytes (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.39MB 506 bytes (-0.01%) ⬇️

@zombieJ zombieJ merged commit 5669073 into next Jan 13, 2025
42 checks passed
@zombieJ zombieJ deleted the v6-kiner-retire-deprecated-api-slider branch January 13, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@MadCcc MadCcc Awaiting requested review from MadCcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiner-tang @zombieJ