Skip to content

feat: [v6] Retire deprecated api for select #52368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: [v6] Retire deprecated api for select #52368

merged 1 commit into from
Jan 13, 2025

Conversation

kiner-tang
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • [-] 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for select
🇨🇳 Chinese select 废弃 api 退休

@kiner-tang kiner-tang requested review from zombieJ and MadCcc January 12, 2025 02:41
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited by kiner-tang
Loading

👁 Visual Regression Report for PR #52368 Failed ❌

🎯 Target branch: next (07c34d9)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request removes the deprecated dropdownClassName API from the Select component in the Ant Design library. The changes involve updating the component's implementation and tests to fully transition to using popupClassName instead.

Changes

Files Summary
components/select/tests/index.test.tsx Removed tests related to the deprecated dropdownClassName and updated tests to ensure compatibility with popupClassName.
components/select/index.tsx Removed dropdownClassName from the component's props and logic, replacing it with popupClassName. Updated internal logic to remove deprecated warnings and ensure proper functionality with the new API.

petercat-assistant[bot]
petercat-assistant bot reviewed Jan 12, 2025
View reviewed changes
components/select/index.tsx
@@ -205,7 +207,7 @@ const InternalSelect = <
const selectProps = omit(rest, ['suffixIcon', 'itemIcon' as any]);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that popupClassName is correctly applied and tested, as dropdownClassName has been removed. Verify that all instances where dropdownClassName was used are now replaced with popupClassName to avoid any potential issues.

@kiner-tang kiner-tang mentioned this pull request Jan 12, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 445.29 KB (-22 B 🔽)
dist/antd-with-locales.min.js 513.49 KB (-31 B 🔽)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52368

commit: f41e98f

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025

Bundle Report

Changes will increase total bundle size by 6.32MB (186.38%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 9.71MB 6.32MB (186.38%) ⬆️⚠️

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: f41e98f
Status: ✅  Deploy successful!
Preview URL: https://b8f9182f.ant-design.pages.dev
Branch Preview URL: https://v6-kiner-retire-deprecated-a-kibl.ant-design.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (07c34d9) to head (f41e98f).
Report is 16 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52368   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13699     13697    -2     
  Branches      3581      3580    -1     
=========================================
- Hits         13699     13697    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit ff3bee9 into next Jan 13, 2025
47 checks passed
@zombieJ zombieJ deleted the v6-kiner-retire-deprecated-api-select branch January 13, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@MadCcc MadCcc Awaiting requested review from MadCcc

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiner-tang @zombieJ