feat: [v6] Retire deprecated api for form #52235

kiner-tang · 2025-01-04T03:58:51Z

🤔 This is a ...

🔗 Related Issues

Ant Design v6 tasks #52115

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Retire deprecated api for form
🇨🇳 Chinese	form 废弃 api 退休

bolt-new-by-stackblitz · 2025-01-04T03:58:54Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-01-04T03:59:03Z

github-actions · 2025-01-04T03:59:04Z

👁 Visual Regression Report for PR #52235 Failed ❌

🎯 Target branch: next (07c34d9)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next)	Actual (Current PR)	Diff
input-group.compact.png	input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

Visual diff is acceptable

petercat-assistant · 2025-01-04T03:59:06Z

Walkthrough

This pull request focuses on retiring deprecated APIs related to forms in the Ant Design library. The changes involve removing deprecated properties and methods, such as hideRequiredMark, fieldKey, and Form.create, from various components and test files. This update aims to clean up the codebase by eliminating outdated functionalities.

Changes

Files	Summary
components/form/Form.tsx, components/form/FormItem/index.tsx, components/form/FormList.tsx	Removed deprecated properties `hideRequiredMark` and `fieldKey`.
components/form/tests/index.test.tsx	Removed tests related to deprecated features like `Form.create` and `hideRequiredMark`.
components/form/index.tsx	Removed the deprecated `Form.create` method and related warnings.

petercat-assistant · 2025-01-04T03:59:09Z

components/form/Form.tsx

    if (contextForm && contextForm.requiredMark !== undefined) {
      return contextForm.requiredMark;
    }

    return true;
-  }, [hideRequiredMark, requiredMark, contextForm]);
+  }, [requiredMark, contextForm]);


Ensure that removing hideRequiredMark does not affect any existing functionality that relies on this property. Double-check if any external dependencies or documentation still reference this property.

github-actions · 2025-01-04T04:01:26Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	445.29 KB (-26 B 🔽)
`dist/antd-with-locales.min.js`	513.49 KB (-31 B 🔽)

pkg-pr-new · 2025-01-04T04:02:14Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52235

commit: cd5215d

cloudflare-workers-and-pages · 2025-01-04T04:07:05Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`cd5215d`
Status:	✅ Deploy successful!
Preview URL:	https://c1699e72.ant-design.pages.dev
Branch Preview URL:	https://v6-kiner-retire-deprecated-a-ctwu.ant-design.pages.dev

View logs

codecov · 2025-01-04T11:32:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b75fd72) to head (cd5215d).
Report is 55 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #52235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       760    -3     
  Lines        13734     13695   -39     
  Branches      3585      3580    -5     
=========================================
- Hits         13734     13695   -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/drawer/demo/form-in-drawer.tsx

codecov · 2025-01-08T00:56:33Z

Bundle Report

Changes will decrease total bundle size by 2.76kB (-0.08%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.37MB	2.76kB (-0.08%) ⬇️

feat: Retire deprecated api for form

7a44e37

kiner-tang requested review from zombieJ and crazyair January 4, 2025 03:58

petercat-assistant bot reviewed Jan 4, 2025

View reviewed changes

feat: Retire deprecated api for form

a0bb5b1

kiner-tang mentioned this pull request Jan 4, 2025

Ant Design v6 tasks #52115

Open

kiner-tang added 2 commits January 4, 2025 19:05

feat: Retire deprecated api for form

6cb95a3

feat: Retire deprecated api for form

711085a

zombieJ reviewed Jan 7, 2025

View reviewed changes

components/drawer/demo/form-in-drawer.tsx Outdated Show resolved Hide resolved

feat: opt code

5f6300c

kiner-tang requested a review from zombieJ January 8, 2025 00:54

kiner-tang added 3 commits January 11, 2025 10:33

feat: opt code

539f444

feat: opt code

93d0615

feat: opt code

cd5215d

zombieJ approved these changes Jan 13, 2025

View reviewed changes

zombieJ merged commit 50bee02 into next Jan 13, 2025
41 checks passed

zombieJ deleted the v6-kiner-retire-deprecated-api-form branch January 13, 2025 09:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: [v6] Retire deprecated api for form #52235

feat: [v6] Retire deprecated api for form #52235

Uh oh!

kiner-tang commented Jan 4, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Jan 4, 2025

Uh oh!

github-actions bot commented Jan 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 4, 2025 •

edited by kiner-tang

Loading

Uh oh!

petercat-assistant bot commented Jan 4, 2025

Uh oh!

petercat-assistant bot Jan 4, 2025

Uh oh!

github-actions bot commented Jan 4, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 4, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jan 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jan 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jan 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: [v6] Retire deprecated api for form #52235

feat: [v6] Retire deprecated api for form #52235

Uh oh!

Conversation

kiner-tang commented Jan 4, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Jan 4, 2025

Uh oh!

github-actions bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2025 • edited by kiner-tang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #52235 Failed ❌

Uh oh!

petercat-assistant bot commented Jan 4, 2025

Walkthrough

Changes

Uh oh!

petercat-assistant bot Jan 4, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

codecov bot commented Jan 8, 2025

Bundle Report

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2025 •

edited

Loading

github-actions bot commented Jan 4, 2025 •

edited by kiner-tang

Loading

github-actions bot commented Jan 4, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 4, 2025 •

edited

Loading

codecov bot commented Jan 4, 2025 •

edited

Loading