Skip to content

feat: Add customize icon #52216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jan 15, 2025
Merged

feat: Add customize icon #52216

merged 37 commits into from
Jan 15, 2025

Conversation

wanpan11
Copy link
Member

@wanpan11 wanpan11 commented Jan 3, 2025 •
edited
Loading

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

💡 Background and Solution

自定义操作图标

📝 Change Log

Language Changelog
🇺🇸 English Add customize handle elements and style
🇨🇳 Chinese 新增自定义交互图标

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited by wanpan11
Loading

👁 Visual Regression Report for PR #52216 Failed ❌

🎯 Target branch: next (1f50049)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed, 🆕 6 added

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png
splitter-customize.compact.css-var.png splitter-customize.compact.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
splitter-customize.compact.png splitter-customize.compact.png 🆕🆕🆕 Added 🆕🆕🆕
splitter-customize.dark.css-var.png splitter-customize.dark.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
splitter-customize.dark.png splitter-customize.dark.png 🆕🆕🆕 Added 🆕🆕🆕
splitter-customize.default.css-var.png splitter-customize.default.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
splitter-customize.default.png splitter-customize.default.png 🆕🆕🆕 Added 🆕🆕🆕

Important

There are 7 diffs found in this PR: 🔄 1 changed, 🆕 6 added.
Please check all items:

  • Visual diff is acceptable

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request introduces a new feature that allows for the customization of icons within the splitter component. It adds support for custom dragger and collapsible icons, enhancing the flexibility and visual customization of the component.

Changes

Files Summary
components/splitter/SplitBar.tsx, components/splitter/Splitter.tsx, components/splitter/interface.ts Added support for custom dragger and collapsible icons in the splitter component.
components/splitter/tests/index.test.tsx Added tests for the new customization feature.
components/splitter/demo/customize.md, components/splitter/demo/customize.tsx Added a demo showcasing the customization of icons.
components/splitter/index.en-US.md, components/splitter/index.zh-CN.md Updated documentation to include the new customization options.
components/splitter/style/index.ts Updated styles to support the new customizable icons.

petercat-assistant[bot]
petercat-assistant bot reviewed Jan 3, 2025
View reviewed changes
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 3, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52216

commit: 84208a2

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1f50049) to head (84208a2).
Report is 2 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13681     13693   +12     
  Branches      3576      3582    +6     
=========================================
+ Hits         13681     13693   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 5.88kB (0.17%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.39MB 5.88kB (0.17%) ⬆️

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 3, 2025

Bundle Report

Changes will increase total bundle size by 1.7kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.37MB 1.7kB (0.05%) ⬆️

1.7K ？不少哦

@wanpan11
Copy link
Member Author

wanpan11 commented Jan 3, 2025 •
edited
Loading

1.7K ？不少哦

感觉没加几行代码呀 😂

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 3, 2025

我的意思也是没几行，怎么多1K多，会不会哪里弄错了。

li-jia-nan
li-jia-nan reviewed Jan 3, 2025
View reviewed changes
wanpan11 and others added 2 commits January 3, 2025 13:36
@wanpan11 @li-jia-nan
Update components/splitter/SplitBar.tsx
836f61c 
Co-authored-by: lijianan <574980606@qq.com>
Signed-off-by: Wanpan <wanpan96@163.com>
@wanpan11
Merge branch 'feature' into splitter
5633abc
li-jia-nan
li-jia-nan reviewed Jan 3, 2025
View reviewed changes
@li-jia-nan
Copy link
Member

这个挪到 next 分支吧

@wanpan11 wanpan11 changed the base branch from feature to next January 4, 2025 13:36
@wanpan11 @li-jia-nan
Update components/splitter/index.zh-CN.md
88311b7 
Co-authored-by: lijianan <574980606@qq.com>
Signed-off-by: Wanpan <wanpan96@163.com>
li-jia-nan
li-jia-nan reviewed Jan 4, 2025
View reviewed changes
li-jia-nan
li-jia-nan reviewed Jan 4, 2025
View reviewed changes
li-jia-nan
li-jia-nan reviewed Jan 4, 2025
View reviewed changes
@li-jia-nan li-jia-nan mentioned this pull request Jan 4, 2025
Open
@wanpan11
Copy link
Member Author

wanpan11 commented Jan 5, 2025 •
edited
Loading

@li-jia-nan 佬 这个 pr 定制不了分割线样式我改了引用，
@zombieJ 还有个问题 splitter 的分割线是用 ::before 做的弄不了语义化 class/style，只能用 token 处理。
下个 pr 我再处理分割线

@li-jia-nan
Copy link
Member

@li-jia-nan 佬 这个 pr 定制不了分割线样式我改了引用， @zombieJ 还有个问题 splitter 的分割线是用 ::before 做的弄不了语义化 class/style，只能用 token 处理。 下个 pr 我再处理分割线

啊，那是我弄错了

zombieJ
zombieJ reviewed Jan 10, 2025
View reviewed changes
zombieJ
zombieJ reviewed Jan 10, 2025
View reviewed changes
zombieJ
zombieJ reviewed Jan 14, 2025
View reviewed changes
zombieJ
zombieJ reviewed Jan 14, 2025
View reviewed changes
@wanpan11 wanpan11 requested a review from zombieJ January 14, 2025 06:25
@zombieJ zombieJ merged commit 0df33b2 into ant-design:next Jan 15, 2025
37 checks passed
@wanpan11 wanpan11 deleted the splitter branch January 16, 2025 01:03
@wanpan11 wanpan11 mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jia-nan li-jia-nan li-jia-nan left review comments

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanpan11 @yoyo837 @li-jia-nan @zombieJ