Skip to content

chore: [v6] rm legacy BackTop component #52206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2025
Merged

chore: [v6] rm legacy BackTop component #52206

merged 5 commits into from
Jan 6, 2025

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 2, 2025 •
edited
Loading

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

image

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English 删除 v5 已废弃的组件
🇨🇳 Chinese 删除 v5 已废弃的组件

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited by li-jia-nan
Loading

👁 Visual Regression Report for PR #52206 Failed ❌

🎯 Target branch: next (8e8f4e7)
📖 View Full Report ↗︎

Expected (Branch next) Actual (Current PR) Diff
auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png
auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.css-var.png auto-complete-uncertain-category.compact.css-var.png
avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.png
avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.css-var.png avatar-dynamic.compact.css-var.png
badge-change.compact.png badge-change.compact.png badge-change.compact.png badge-change.compact.png
badge-change.compact.png badge-change.compact.png badge-change.compact.css-var.png badge-change.compact.css-var.png
button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.png
button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.css-var.png button-color-variant.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 350 diffs found in this PR: 🔄 314 changed, 🆕 36 added.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request focuses on refactoring by removing the legacy BackTop component from the codebase. The changes involve deleting the component's implementation, associated tests, and documentation. The BackTop component was deprecated in favor of FloatButton.BackTop.

Changes

Files Summary
components/back-top/** Removed all files related to the BackTop component, including tests, demos, and styles.
components/config-provider/tests/components.test.tsx Removed BackTop import and related test cases.
components/index.ts Removed BackTop export and type definitions.
components/theme/interface/components.ts Removed BackTop component token type definition.
components/tests/snapshots/** Deleted snapshot files related to the BackTop component.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 440.55 KB (-664 B 🔽)
dist/antd-with-locales.min.js 508.76 KB (-665 B 🔽)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 2, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52206

commit: a20ec4f

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 2, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: a20ec4f
Status: ✅  Deploy successful!
Preview URL: https://73a38dd5.ant-design.pages.dev
Branch Preview URL: https://v6-rm-backtop.ant-design.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025

Bundle Report

Changes will decrease total bundle size by 5.08kB (-0.15%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.36MB 5.08kB (-0.15%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b75fd72) to head (a20ec4f).
Report is 9 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       761    -2     
  Lines        13734     13686   -48     
  Branches      3585      3577    -8     
=========================================
- Hits         13734     13686   -48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan mentioned this pull request Jan 4, 2025
Open
@zombieJ zombieJ merged commit 8b2cc4a into next Jan 6, 2025
41 checks passed
@zombieJ zombieJ deleted the v6-rm-backtop branch January 6, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@li-jia-nan @zombieJ