Skip to content

feat: [V6] Retire deprecated api for AutoComplete #52198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat: [V6] Retire deprecated api for AutoComplete #52198

merged 1 commit into from
Jan 2, 2025

Conversation

kiner-tang
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for AutoComplete
🇨🇳 Chinese AutoComplete 废弃 api 退休

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025 •
edited
Loading

👁 Visual Regression Report for PR #52198 Passed ✅

🎯 Target branch: next (a8a7f31)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request removes deprecated APIs related to the AutoComplete component in the Ant Design library. Specifically, it retires the dropdownClassName property in favor of popupClassName, and updates the associated tests and component logic accordingly.

Changes

File Summary
components/auto-complete/tests/index.test.tsx Removed tests related to the deprecated dropdownClassName property.
components/auto-complete/index.tsx Removed the dropdownClassName property and its usage in favor of popupClassName. Updated component logic to reflect this change.

petercat-assistant[bot]
petercat-assistant bot reviewed Jan 1, 2025
View reviewed changes
components/auto-complete/index.tsx
@@ -135,9 +124,9 @@ const AutoComplete: React.ForwardRefRenderFunction<RefSelectProps, AutoCompleteP
<Select
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of dropdownClassName in favor of popupClassName is a breaking change. Ensure that all dependent code and documentation are updated accordingly to prevent any unexpected behavior.

@kiner-tang kiner-tang mentioned this pull request Jan 1, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

size-limit report 📦

Path Size
dist/antd.min.js 442.37 KB (-13 B 🔽)
dist/antd-with-locales.min.js 510.46 KB (-13 B 🔽)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 1, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52198

commit: 7a44c37

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a44c37
Status: ✅  Deploy successful!
Preview URL: https://50660d4c.ant-design.pages.dev
Branch Preview URL: https://v6-kiner-retire-deprecated-a.ant-design.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8a7f31) to head (7a44c37).
Report is 4 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13650     13648    -2     
  Branches      3563      3562    -1     
=========================================
- Hits         13650     13648    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 8e8f4e7 into next Jan 2, 2025
46 checks passed
@zombieJ zombieJ deleted the v6-kiner-retire-deprecated-api-auto-complete branch January 2, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@afc163 afc163 Awaiting requested review from afc163

@MadCcc MadCcc Awaiting requested review from MadCcc

@li-jia-nan li-jia-nan Awaiting requested review from li-jia-nan

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiner-tang @zombieJ