feat: ConfigProvider support classNames and styles for Result #52171

thinkasany · 2024-12-30T04:32:48Z

🤔 This is a ...

🆕 New feature

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classNames and styles for Result
🇨🇳 Chinese	feat: ConfigProvider 支持 Result 组件的classNames 和styles 配置

bolt-new-by-stackblitz · 2024-12-30T04:32:52Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2024-12-30T04:33:00Z

👁 Visual Regression Report for PR #52171 Passed ✅

🎯 Target branch: next (89c1a05)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

github-actions · 2024-12-30T04:33:01Z

petercat-assistant · 2024-12-30T04:33:05Z

Walkthrough

This pull request introduces a new feature to the ConfigProvider component, allowing it to support classNames and styles for the Result component. This enhancement provides developers with more flexibility in customizing the appearance of the Result component by specifying custom class names and styles.

Changes

Files Changed	Summary
components/config-provider/context.ts	Added `ResultConfig` type to support `classNames` and `styles` for `Result`.
components/config-provider/index.en-US.md	Updated documentation to include `classNames` and `styles` for `Result`.
components/config-provider/index.zh-CN.md	Updated Chinese documentation to include `classNames` and `styles` for `Result`.
components/result/tests/index.test.tsx	Added tests to verify custom styles and class names are applied to `Result`.
components/result/demo/_semantic.tsx	Added a new demo showcasing semantic DOM usage for `Result`.
components/result/index.en-US.md	Added semantic DOM section to English documentation.
components/result/index.tsx	Enhanced `Result` component to accept `classNames` and `styles` props.
components/result/index.zh-CN.md	Added semantic DOM section to Chinese documentation.

petercat-assistant · 2024-12-30T04:33:08Z

components/result/index.tsx

@@ -52,14 +68,13 @@ const ExceptionStatus = Object.keys(ExceptionMap);
 */

 interface IconProps {


The IconProps interface has been modified to replace prefixCls with className and added an optional style property. Ensure that all usages of IconProps are updated accordingly to prevent potential runtime errors.

pkg-pr-new · 2024-12-30T04:36:14Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52171

commit: 1523cf8

codecov · 2024-12-30T04:45:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89c1a05) to head (1523cf8).
Report is 1 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #52171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13643     13650    +7     
  Branches      3561      3563    +2     
=========================================
+ Hits         13643     13650    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zombieJ · 2024-12-30T06:41:24Z

components/result/demo/_semantic.tsx

+    subTitle: '副标题元素',
+    body: '内容元素',
+    extra: '额外元素',
+    image: '图标元素',


这个应该是 icon？

codecov · 2024-12-30T07:25:57Z

Bundle Report

Changes will increase total bundle size by 5.08kB (0.15%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.38MB	5.08kB (0.15%) ⬆️

zombieJ · 2024-12-30T09:36:20Z

components/result/index.tsx

+  );
+
+  const bodyClassNames = classNames(
+    `${prefixCls}-content`,


这里也要变成 body，否则会让人疑惑的。挪到 next 里吧。

zombieJ · 2024-12-31T03:51:21Z

components/result/index.tsx

+  );
+
+  const bodyClassNames = classNames(
+    `${prefixCls}-body`,


这边替换后，style/index.ts 里的没有替换。

petercat-assistant bot reviewed Dec 30, 2024

View reviewed changes

thinkasany mentioned this pull request Dec 30, 2024

Ant Design v6 tasks #52115

Open

zombieJ reviewed Dec 30, 2024

View reviewed changes

thinkasany force-pushed the cp-result branch from 9da6cb2 to 93f0955 Compare December 30, 2024 10:53

feat: ConfigProvider support classNames and styles for Result

fb8089d

thinkasany force-pushed the cp-result branch from 93f0955 to fb8089d Compare December 30, 2024 10:58

update content to body

1059bf1

thinkasany changed the base branch from feature to next December 30, 2024 11:02

update version to 6.0.0

eb8a917

thinkasany requested a review from zombieJ December 30, 2024 11:58

zombieJ reviewed Dec 31, 2024

View reviewed changes

update body

1523cf8

zombieJ approved these changes Dec 31, 2024

View reviewed changes

zombieJ merged commit 6f2b330 into ant-design:next Dec 31, 2024
37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: ConfigProvider support classNames and styles for Result #52171

feat: ConfigProvider support classNames and styles for Result #52171

Uh oh!

thinkasany commented Dec 30, 2024

Uh oh!

bolt-new-by-stackblitz bot commented Dec 30, 2024

Uh oh!

github-actions bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

petercat-assistant bot commented Dec 30, 2024

Uh oh!

petercat-assistant bot Dec 30, 2024

Uh oh!

pkg-pr-new bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

zombieJ Dec 30, 2024

Uh oh!

codecov bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

zombieJ Dec 30, 2024

Uh oh!

thinkasany Dec 30, 2024

Uh oh!

zombieJ Dec 31, 2024

Uh oh!

Uh oh!

Uh oh!

		@@ -52,14 +68,13 @@ const ExceptionStatus = Object.keys(ExceptionMap);
		*/

		interface IconProps {

Uh oh!

feat: ConfigProvider support classNames and styles for Result #52171

feat: ConfigProvider support classNames and styles for Result #52171

Uh oh!

Conversation

thinkasany commented Dec 30, 2024

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Dec 30, 2024

Uh oh!

github-actions bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #52171 Passed ✅

Uh oh!

github-actions bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant bot commented Dec 30, 2024

Walkthrough

Changes

Uh oh!

petercat-assistant bot Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zombieJ Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

zombieJ Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

thinkasany Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

zombieJ Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading