Skip to content

feat: ConfigProvider support classNames and styles for Statistic #52141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 7, 2025
Merged

feat: ConfigProvider support classNames and styles for Statistic #52141

merged 5 commits into from
Jan 7, 2025

Conversation

thinkasany
Copy link
Member

@thinkasany thinkasany commented Dec 26, 2024 •
edited
Loading

🤔 This is a ...

  • 🆕 New feature

讨论结果

修正 dom 结构，尊重语义化结构规范， 改为 header 包裹 title的形式，纠正进 next 分支，v5 不允许 breakchange。

🔗 Related

语义化基本复用 #51885

但是 title 确实需要斟酌，符合 原有的 classname 的 title。

不过 modal 组件是因为本身dom那层的classname就命名为header，所以感觉可以启用 title , 待讨论。

这边的坑是： title 和 header的区别是： 是否包含 padding， 但是这边来了个 margin-bottom

image

image
image

📝 Change Log

Language Changelog
🇺🇸 English feat: ConfigProvider support classNames and styles for Statistic
🇨🇳 Chinese feat: ConfigProvider 支持 Statistic 组件配置 classNames 和styles

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited by zombieJ
Loading

👁 Visual Regression Report for PR #52141 Failed ❌

🎯 Target branch: next (8e8f4e7)
📖 View Full Report ↗︎

Expected (Branch next) Actual (Current PR) Diff
auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png
auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.css-var.png auto-complete-uncertain-category.compact.css-var.png
avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.png
avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.css-var.png avatar-dynamic.compact.css-var.png
badge-change.compact.png badge-change.compact.png badge-change.compact.png badge-change.compact.png
badge-change.compact.png badge-change.compact.png badge-change.compact.css-var.png badge-change.compact.css-var.png
button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.png
button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.css-var.png button-color-variant.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 359 diffs found in this PR: 🔄 323 changed, 🆕 36 added.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited
Loading

Preview is ready

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request introduces a new feature that allows the ConfigProvider to support classNames and styles for the Statistic component. This enhancement provides more flexibility in styling and customizing the appearance of the Statistic component.

Changes

File Summary
components/config-provider/context.ts Added StatisticConfig to support classNames and styles for the Statistic component.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md Updated documentation to reflect the new classNames and styles support for Statistic.
components/statistic/Statistic.tsx Implemented classNames and styles properties in the Statistic component.
components/statistic/tests/index.test.tsx Added tests to verify custom styles and class names for the Statistic component.
components/statistic/demo/_semantic.tsx Added a demo showcasing the semantic DOM structure for the Statistic component.
components/statistic/index.en-US.md, components/statistic/index.zh-CN.md Updated documentation to include semantic DOM information for the Statistic component.

petercat-assistant[bot]
petercat-assistant bot reviewed Dec 26, 2024
View reviewed changes
components/statistic/Statistic.tsx Outdated
};
styles?: {
root?: React.CSSProperties;
content?: React.CSSProperties;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the styles object is properly validated to prevent potential security risks such as CSS injection.

@thinkasany thinkasany mentioned this pull request Dec 26, 2024
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 26, 2024 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52141

commit: 8c52474

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b75fd72) to head (8c52474).
Report is 20 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13734     13745   +11     
  Branches      3585      3588    +3     
=========================================
+ Hits         13734     13745   +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkasany thinkasany force-pushed the cp-Statistic branch 3 times, most recently from 44362da to a83b93a Compare January 3, 2025 13:30
@thinkasany thinkasany changed the base branch from feature to next January 3, 2025 13:31
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 6.25MB (185.51%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 9.62MB 6.25MB (185.51%) ⬆️⚠️

@zombieJ zombieJ merged commit 5853377 into ant-design:next Jan 7, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @zombieJ