Skip to content

chore: change to install 18 script #52130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2024
Merged

chore: change to install 18 script #52130

merged 3 commits into from
Dec 25, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 25, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024 •
edited
Loading

Preview is ready

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request updates the workflow by modifying the installation scripts in the package.json file to support React version 18. The changes involve removing the scripts for installing React versions 16 and 17 and adding new scripts for React version 18.

Changes

File Summary
package.json Removed installation scripts for React 16 and 17, added scripts for React 18 installation using both npm and bun.

petercat-assistant[bot]
petercat-assistant bot reviewed Dec 25, 2024
View reviewed changes
package.json
"install-react-17": "npm i --no-save --legacy-peer-deps react@17 react-dom@17 @testing-library/react@12",
"bun-install-react-16": "bun remove react react-dom @testing-library/react && bun add --no-save react@16 react-dom@16 @testing-library/react@12",
"bun-install-react-17": "bun remove react react-dom @testing-library/react && bun add --no-save react@17 react-dom@17 @testing-library/react@12",
"install-react-18": "npm i --no-save --legacy-peer-deps react@18 react-dom@18 @testing-library/react@16",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that all dependencies and peer dependencies are compatible with React 18 to prevent potential runtime issues.

@socket-security Socket Security
Copy link

socket-security bot commented Dec 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/isomorphic-fetch@3.0.0 Transitive: network +1 169 kB mattandrews

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 442.39 KB
dist/antd-with-locales.min.js 510.46 KB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 25, 2024 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52130

commit: a0b2b6a

thinkasany
thinkasany previously approved these changes Dec 25, 2024
View reviewed changes
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 25, 2024 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: a0b2b6a
Status: ✅  Deploy successful!
Preview URL: https://ef59e78b.ant-design.pages.dev
Branch Preview URL: https://script-18.ant-design.pages.dev

View logs

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024 •
edited
Loading

👁 Visual Regression Report for PR #52130 Passed ✅

🎯 Target branch: next (491dfce)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (491dfce) to head (a0b2b6a).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13643     13643           
  Branches      3561      3561           
=========================================
  Hits         13643     13643

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jia-nan
li-jia-nan previously approved these changes Dec 25, 2024
View reviewed changes
@zombieJ zombieJ dismissed stale reviews from li-jia-nan and thinkasany via a0b2b6a December 25, 2024 09:57
@zombieJ zombieJ merged commit 113203a into next Dec 25, 2024
41 checks passed
@zombieJ zombieJ deleted the script-18 branch December 25, 2024 10:41
@zombieJ zombieJ mentioned this pull request Dec 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

@li-jia-nan li-jia-nan li-jia-nan left review comments

@thinkasany thinkasany thinkasany left review comments

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zombieJ @afc163 @li-jia-nan @thinkasany