Skip to content

feat: ConfigProvider support popconfirm #52126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2024
Merged

feat: ConfigProvider support popconfirm #52126

merged 3 commits into from
Dec 25, 2024

Conversation

thinkasany
Copy link
Member

@thinkasany thinkasany commented Dec 25, 2024 •
edited
Loading

🤔 This is a ...

  • 🆕 New feature

close #50303

📝 Change Log

Language Changelog
🇺🇸 English feat: ConfigProvider support popconfirm
🇨🇳 Chinese feat: ConfigProvider 支持 popconfirm

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024 •
edited by zombieJ
Loading

👁 Visual Regression Report for PR #52126 Failed ❌

🎯 Target branch: feature (ca1ab9b)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
button-color-variant.dark.png button-color-variant.dark.png button-color-variant.dark.css-var.png button-color-variant.dark.css-var.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.css-var.png button-debug-color-variant.compact.css-var.png
button-debug-color-variant.dark.png button-debug-color-variant.dark.png button-debug-color-variant.dark.css-var.png button-debug-color-variant.dark.css-var.png
button-debug-color-variant.default.png button-debug-color-variant.default.png button-debug-color-variant.default.css-var.png button-debug-color-variant.default.css-var.png
checkbox-custom-line-width.compact.png checkbox-custom-line-width.compact.png checkbox-custom-line-width.compact.css-var.png checkbox-custom-line-width.compact.css-var.png
checkbox-custom-line-width.dark.png checkbox-custom-line-width.dark.png checkbox-custom-line-width.dark.css-var.png checkbox-custom-line-width.dark.css-var.png
checkbox-custom-line-width.default.png checkbox-custom-line-width.default.png checkbox-custom-line-width.default.css-var.png checkbox-custom-line-width.default.css-var.png
checkbox-debug-line.compact.png checkbox-debug-line.compact.png checkbox-debug-line.compact.css-var.png checkbox-debug-line.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 34 diffs found in this PR: 🔄 34 changed.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024 •
edited
Loading

Preview is ready

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This pull request introduces a new feature to the ConfigProvider by adding support for Popconfirm. It includes changes to various components to replace deprecated properties with new ones, enhancing the styling and configuration capabilities of Popconfirm and related components.

Changes

Files Summary
.dumi/theme/builtins/ComponentTokenTable/index.tsx, .dumi/theme/slots/Header/index.tsx, components/avatar/tests/Avatar.test.tsx, components/avatar/group.tsx, components/color-picker/ColorPicker.tsx, components/input/demo/tooltip.tsx, components/select/demo/responsive.tsx, components/slider/index.tsx, components/table/tests/Table.sorter.test.tsx, components/tooltip/tests/tooltip.test.tsx Replaced deprecated overlayClassName and overlayStyle with classNames and styles for better styling control.
components/config-provider/context.ts, components/config-provider/index.tsx Added PopconfirmConfig type and integrated it into ConfigProvider for Popconfirm support.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md Updated documentation to include Popconfirm configuration details.
components/popconfirm/tests/index.test.tsx Added tests for custom styles and classNames in Popconfirm.
components/popconfirm/demo/_semantic.tsx Added a semantic demo for Popconfirm.
components/popconfirm/index.en-US.md, components/popconfirm/index.zh-CN.md Added semantic DOM section for Popconfirm documentation.
components/tooltip/index.tsx Updated deprecation warnings to reflect new property usage.

petercat-assistant[bot]
petercat-assistant bot reviewed Dec 25, 2024
View reviewed changes
components/popconfirm/index.tsx
...restProps
} = props;

const { getPrefixCls } = React.useContext(ConfigContext);
const { getPrefixCls, popconfirm } = React.useContext(ConfigContext);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the popconfirm context value is correctly provided and used within the component. If popconfirm is undefined, it might lead to runtime errors when accessing its properties. Consider adding a default value or a check before accessing popconfirm properties.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 25, 2024 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52126

commit: c0fad7a

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca1ab9b) to head (c0fad7a).
Report is 1 commits behind head on feature.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #52126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13726     13727    +1     
  Branches      3585      3585           
=========================================
+ Hits         13726     13727    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkasany thinkasany changed the title feat: ConfigProvider support popcomfirm feat: ConfigProvider support popconfirm Dec 25, 2024
@zombieJ zombieJ merged commit 8b15b0f into ant-design:feature Dec 25, 2024
45 checks passed
This was referenced Dec 25, 2024
Closed
Open
@zombieJ zombieJ mentioned this pull request Jan 6, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @zombieJ