systemd - fix issue with unknown capabilities in newer kernel #72337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug existed in systemd 245 that did not properly handle unknown kernel capabilities gracefully. This resulted in incomplete output when querying for the service status. It is possible to get service status by other means. This PR works around this issue by getting service status using other commands in the event of a failure due to this bug.
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Oct 26, 2020
…le#72337) A bug existed in systemd 245 that did not properly handle unknown kernel capabilities gracefully. This resulted in incomplete output when querying for the service status. It is possible to get service status by other means. This PR works around this issue by getting service status using other commands in the event of a failure due to this bug. (cherry picked from commit db84e2c) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Oct 26, 2020
…e#72337) A bug existed in systemd 245 that did not properly handle unknown kernel capabilities gracefully. This resulted in incomplete output when querying for the service status. It is possible to get service status by other means. This PR works around this issue by getting service status using other commands in the event of a failure due to this bug. (cherry picked from commit db84e2c) Co-authored-by: Sam Doran <sdoran@redhat.com>
This was referenced Oct 26, 2020
3 tasks
evrardjp
added a commit
to evrardjp/ansible-keepalived
that referenced
this pull request
Nov 2, 2020
Without this, molecule testing and some other environments are broken and can't install keepalived. This should fix it until the fix above is backported to stable Ansible branches.
evrardjp
added a commit
to evrardjp/ansible-keepalived
that referenced
this pull request
Nov 3, 2020
Without this, molecule testing and some other environments are broken and can't install keepalived. This should fix it until the fix above is backported to stable Ansible branches.
evrardjp
added a commit
to evrardjp/ansible-keepalived
that referenced
this pull request
Nov 3, 2020
| elif err and rc == 1 and 'Failed to parse bus message' in err: | ||
| result['status'] = parse_systemctl_show(to_native(out).split('\n')) | ||
|
|
||
| (rc, out, err) = module.run_command("{systemctl} list-units '{unit}*'".format(systemctl=systemctl, unit=unit)) |
There was a problem hiding this comment.
@samdoran I believe you should use systemctl list-units --all . Without --all flag the inactive (dead) services will be not listed. Plz see my comment for more info #71528 (comment)
root@Ubuntu18:/# systemctl list-units actions.runner.monolithprojects-ansible-github_actions_runne.Ubuntu18.service
0 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.
root@Ubuntu18:/# systemctl list-units --all actions.runner.monolithprojects-ansible-github_actions_runne.Ubuntu18.service
UNIT LOAD ACTIVE SUB DESCRIPTION
actions.runner.monolithprojects-ansible-github_actions_runne.Ubuntu18.service loaded inactive dead GitHub Actions Runner (monolithprojects-ansible-github_actions_runner-testrepo.Ubuntu18)
1 loaded units listed.
To show all installed unit files use 'systemctl list-unit-files'.
There was a problem hiding this comment.
Have you tried with #72363? I believe list-unit-files should take care of this issue.
There was a problem hiding this comment.
Ah sorry, did not notice that open PR. Yes list-unit-files works too. Thanks.
There was a problem hiding this comment.
Ok, that's great news. Thank you for confirming. I was hoping I didn't have to fix this yet again. :) I have opened backport PRs for 2.9 and 2.10, so this fix will be in the next .z release of Ansible 2.9 and 2.10.
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Nov 20, 2020
Related to issue ansible#71528 and PR ansible#72337 Co-authored-by: Martin Polden <mpolden@mpolden.no>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A bug existed in
systemd245 that did not properly handle unknown kernel capabilities gracefully. This resulted in incomplete output and anrcof 1 when querying for the service status. It is possible to get service status by other means. This PR works around this issue by getting service status using other commands in the event of a failure due to this bug.Fixes #71528
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/systemd.pyADDITIONAL INFORMATION
I'm not sure of a good way to test this. I setup a Fedora 32 VM running the 5.8 kernel and
systemd-245.4-1.fc32.src.rpm. Our Fedora 32 test image hassystemd-245.6-2.fc32.x86_64but the kernel version of the Docker host would need to be 5.8 in order to invoke the failure.Since this is a very specific workaround to a bug that is already fixed, it may be ok to not have tests for this PR.