Skip to content

Changes process lists search for matching fov and mask names to use a… #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 27, 2024
Merged

Changes process lists search for matching fov and mask names to use a… #1104

merged 7 commits into from
Feb 27, 2024

Conversation

bryjcannon
Copy link
Contributor

Addresses Issue #1103

@bryjcannon
Changes process lists search for matching fov and mask names to use a…
6ca333b 
… token subsetting strategy rather than a string subsetting one.
@bryjcannon bryjcannon linked an issue Jan 9, 2024 that may be closed by this pull request
marker_quantification.process_lists() returning inappropriate mask_types #1103
Closed
@bryjcannon
Copy link
Contributor Author

Same example_dataset fails as in #1101. All other tests pass.

@alex-l-kong
Copy link
Contributor

@bryjcannon added a simple test for process_lists, confirmed that it matches the correct FOVs to masks even in the case of fov1 and fov10.

alex-l-kong
alex-l-kong approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bryjcannon bryjcannon self-assigned this Jan 10, 2024
@alex-l-kong alex-l-kong mentioned this pull request Jan 22, 2024
Closed
@alex-l-kong alex-l-kong linked an issue Jan 22, 2024 that may be closed by this pull request
FOV names not parsed correctly when running example dataset in 1_Segment_Image_Data.ipynb #1096
Closed
@bryjcannon bryjcannon added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@bryjcannon bryjcannon added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@bryjcannon bryjcannon added this pull request to the merge queue Feb 27, 2024
@bryjcannon bryjcannon removed this pull request from the merge queue due to a manual request Feb 27, 2024
@camisowers camisowers added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 195f2f1 Feb 27, 2024
@camisowers camisowers deleted the 1103-marker_quantificationprocess_lists-returning-inappropriate-mask_types branch February 27, 2024 23:11
@srivarra srivarra added the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-l-kong alex-l-kong alex-l-kong approved these changes

@camisowers camisowers Awaiting requested review from camisowers

Assignees

@bryjcannon bryjcannon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@bryjcannon @alex-l-kong @srivarra @camisowers