-
Notifications
You must be signed in to change notification settings - Fork 30
1100 empty composites masks in ez segmenter notebook #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bryjcannon
merged 22 commits into
main
from
1100-empty-composites-masks-in-ez_segmenter-notebook
Feb 27, 2024
Merged
1100 empty composites masks in ez segmenter notebook #1101
bryjcannon
merged 22 commits into
main
from
1100-empty-composites-masks-in-ez_segmenter-notebook
Feb 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd compromising downstream composite, segmentation pipeline.
…written during composite creation.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…channel_display formats.
alex-l-kong
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Looks good! Once we get the build fixed, it's good to go. |
… longer is whole_cell enforced.
…o call correct skimage.morphology version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Fixes issue in #1100 where float images were not able to be used in composite, mask creation.
How did you implement your changes
Image loading was converted from np.int32 to np.float32, plus additional handling of composite array addition and subtraction functions.
Remaining issues
None as of now, may run into issues if non float or int img datatypes are used.