Skip to content

Conversation

bryjcannon
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?
Fixes issue in #1100 where float images were not able to be used in composite, mask creation.

How did you implement your changes

Image loading was converted from np.int32 to np.float32, plus additional handling of composite array addition and subtraction functions.

Remaining issues

None as of now, may run into issues if non float or int img datatypes are used.

@bryjcannon bryjcannon requested a review from alex-l-kong January 5, 2024 01:50
@bryjcannon bryjcannon linked an issue Jan 5, 2024 that may be closed by this pull request
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bryjcannon bryjcannon self-assigned this Jan 5, 2024
@bryjcannon bryjcannon requested a review from camisowers January 5, 2024 18:53
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@camisowers
Copy link
Contributor

Looks good! Once we get the build fixed, it's good to go.

@bryjcannon bryjcannon added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 871d535 Feb 27, 2024
@bryjcannon bryjcannon deleted the 1100-empty-composites-masks-in-ez_segmenter-notebook branch February 27, 2024 01:56
@srivarra srivarra added the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty composites, masks in ez_segmenter notebook.
4 participants