Skip to content

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fixes #7210 .

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/feature type/feature label Nov 10, 2021
@chuntaojun chuntaojun merged commit 0719200 into alibaba:develop Nov 11, 2021
@KomachiSion KomachiSion deleted the develop-issue#7210 branch November 16, 2021 02:29
EmanuelGi added a commit to EmanuelGi/nacos that referenced this pull request Aug 26, 2022
…ervice discovery. (alibaba#7211)  * Synchronize k8s services.  * Synchronize k8s endpoints.
KomachiSion pushed a commit that referenced this pull request Sep 29, 2022
* [ISSUE#8309] Nacos supports synchronizing service metadata from k8s service discovery. (#7211)  * Synchronize k8s services.  * Synchronize k8s endpoints.

* ApiClient uses the default configuration instead

* Start registered Informers after registering handlers

* Compare oldServicePorts and newServicePorts to determine portChange

* Delete the logic of service renaming judgment

* Fix error in the process of registering instances

* Use independent log

* add k8s sync switch and start informer optimization

* start informer optimization
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
* [ISSUE#8309] Nacos supports synchronizing service metadata from k8s service discovery. (alibaba#7211)  * Synchronize k8s services.  * Synchronize k8s endpoints.

* ApiClient uses the default configuration instead

* Start registered Informers after registering handlers

* Compare oldServicePorts and newServicePorts to determine portChange

* Delete the logic of service renaming judgment

* Fix error in the process of registering instances

* Use independent log

* add k8s sync switch and start informer optimization

* start informer optimization
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
* [ISSUE#8309] Nacos supports synchronizing service metadata from k8s service discovery. (alibaba#7211)  * Synchronize k8s services.  * Synchronize k8s endpoints.

* ApiClient uses the default configuration instead

* Start registered Informers after registering handlers

* Compare oldServicePorts and newServicePorts to determine portChange

* Delete the logic of service renaming judgment

* Fix error in the process of registering instances

* Use independent log

* add k8s sync switch and start informer optimization

* start informer optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add service rest api v2 for naming module.
2 participants