client adapter同个instance配置多个group会共享CanalMsgConsumer，从而出现并发问题 #5175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tks |
agapple
added a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题现象：
kafka模式下同个instance配置多个group，启动必然会出现：KafkaConsumer is not safe for multi-threaded access Error sync and rollback的问题
原因：
每个group都会对应一个AdapterProcessor，AdapterProcessor初始化的时候会通过loader获取CanalMsgConsumer，CanalMsgConsumer实例会被ExtensionLoader缓存在EXTENSION_KEY_INSTANCE，key是name + "-" + key；而这里的key外部只会传入destination，所以导致同个instance多个group都会复用同一个CanalMsgConsumer，在kafka模式下就会出现多线程访问同一个kafkacomsumer的问题
解决方法：
传入destination + "-" + groupId作为key