reduce allocations in RemoteSystemDaemon ActorPath resolution #3842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 7, 2019
| @@ -304,45 +304,26 @@ private void HandleDaemonMsgCreate(DaemonMsgCreate message) | |||
| /// <returns>ActorRef.</returns> | |||
| public override IActorRef GetChild(IEnumerable<string> name) | |||
| { | |||
| var elements = name.ToArray(); | |||
| var path = elements.Join("/"); | |||
There was a problem hiding this comment.
No need for redundant .ToArray + Join call. All of the objects passed into this method are IReadOnlyList<string>
|
|
||
| private IInternalActorRef GetChild(string name) |
There was a problem hiding this comment.
No need for extra GetChild method, which also calls ActorCell.SplitNameAndUid redundantly
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleaned up the API.