Skip to content

working on resolving racy Akka.Streams specs #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 14, 2019

Conversation

Aaronontheweb
Copy link
Member

Trying to deal with the flakiest specs individually - failing that, going to either:

  1. Run the entire test suite serially
  2. Disable some of the worst offenders
  3. Combination of all of the above.

@Aaronontheweb Aaronontheweb force-pushed the disable-racy-StreamsSpecs branch from e9047e7 to 4f989a9 Compare July 13, 2019 12:07
@Aaronontheweb Aaronontheweb marked this pull request as ready for review July 14, 2019 09:19
@Aaronontheweb
Copy link
Member Author

Looks to have settled down now - might play with disabling parallelism on a separate PR later. I suspect our AssertAllStagesStopped functionality is the root cause of the problems these specs had. That and a lot of blocking waits.

@Aaronontheweb Aaronontheweb merged commit 33aea36 into akkadotnet:dev Jul 14, 2019
@Aaronontheweb Aaronontheweb deleted the disable-racy-StreamsSpecs branch July 14, 2019 10:43
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jul 30, 2019
* disable parallelization for Akka.Streams.Tests

* skipped both of the A_Flow_with_SelectAsyncUnordered_must_not_run_more_futures_than_config specs

* disabled some more bad actors

* disabled more of the usual suspects

* more observable sink specs

* marking AggregateAsync with FlowAsync as skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant