fixed solution issues that prevented NuGet publication #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are some left-overs from our original move onto .NET Standard 2.0 - looks like I accidentally left Akka.Persistence.FSharp out of the solution. |
Aaronontheweb
commented
Jun 6, 2019
| @@ -4,7 +4,7 @@ | |||
| <AssemblyTitle>Akka.NodeTestRunner</AssemblyTitle> | |||
| <TargetFrameworks>$(NetFrameworkTestVersion);$(NetCoreTestVersion)</TargetFrameworks> | |||
| <OutputType>Exe</OutputType> | |||
| <RuntimeIdentifiers>win7-x86</RuntimeIdentifiers> | |||
| <RuntimeIdentifiers>win7-x64</RuntimeIdentifiers> | |||
There was a problem hiding this comment.
Needed this to fix MNTR publication.
Aaronontheweb
commented
Jun 6, 2019
| @@ -17,12 +17,4 @@ | |||
| <ProjectReference Include="..\Akka.FSharp\Akka.FSharp.fsproj" /> | |||
| <ProjectReference Include="..\Akka.Persistence\Akka.Persistence.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="FSharp.Core" Version="4.2.3"/> | |||
There was a problem hiding this comment.
Not necessary - we pull these dependencies in from Akka.Persistence.FSharp
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
* fixed solution issues that prevented NuGet publication * fixed last publish bug
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
* fixed solution issues that prevented NuGet publication * fixed last publish bug
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
…otnet#3819)" This reverts commit 14dce3c.
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 26, 2019
* fixed solution issues that prevented NuGet publication * fixed last publish bug
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 30, 2019
* fixed solution issues that prevented NuGet publication * fixed last publish bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.