Fix ForkJoinExecutor / Dispatcher Leak #3734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f ForkJoinDispatcher variants
Aaronontheweb
commented
Mar 11, 2019
| threads.Count.Should().Be(4, "Expected 4 distinct threads in this example"); | ||
|
|
||
| await Sys.Terminate(); | ||
| AwaitAssert(() => threads.Values.All(x => x.IsAlive == false).Should().BeTrue("All threads should be stopped")); |
There was a problem hiding this comment.
This assertion currently fails - the Task from Terminate() completes without killing off any of the ForkJoinExecutor threads.
|
Looks like the real fix to this bug is completing all outstanding work items inside the |
Aaronontheweb
commented
Mar 11, 2019
| { | ||
| try | ||
| { | ||
| task.Action.Run(); |
There was a problem hiding this comment.
So this was the major fix - the JVM has equivalent code too; need to make sure everything gets processed upon IScheduler shutdown.
izavala
reviewed
Mar 12, 2019
This was referenced Mar 12, 2019
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
* close akkadotnet#2640 - fixed shutdown routine of HashedWheelTimerScheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a reproduction spec for #2640 in here, but not a fix yet.