Don't automatically down quarantined nodes #3605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
Sep 29, 2018
| var secondUnique = Cluster.State.Members.SingleOrDefault(m => m.Address == GetAddress(_config.Second) && m.Status == MemberStatus.Up); | ||
| if (secondUnique == null) | ||
| { | ||
| // TODO: fail("Unexpected removal of quarantined node") |
There was a problem hiding this comment.
This should be some sort of assertion fail. Couldn't figure out the api for that in Akka.NET, yet.
There was a problem hiding this comment.
You can just use Fluent Assertions. Lookin at the code from original test:
var secondUniqueAddress = Cluster.State.Members.SingleOrDefault(m => m.Address == GetAddress(_config.Second));
secondUniqueAddress.Should().Not.BeNull(because: "2nd node should stay visible");
secondUniqueAddress.Status.Should().Be(MemberStatus.Up, because: "2nd node should be Up");
Horusiath
reviewed
Sep 29, 2018
There was a problem hiding this comment.
Only one case (missing assertion, @ismaelhamed pointed himself). Beside that, it's good to go 👍
| var secondUnique = Cluster.State.Members.SingleOrDefault(m => m.Address == GetAddress(_config.Second) && m.Status == MemberStatus.Up); | ||
| if (secondUnique == null) | ||
| { | ||
| // TODO: fail("Unexpected removal of quarantined node") |
There was a problem hiding this comment.
You can just use Fluent Assertions. Lookin at the code from original test:
var secondUniqueAddress = Cluster.State.Members.SingleOrDefault(m => m.Address == GetAddress(_config.Second));
secondUniqueAddress.Should().Not.BeNull(because: "2nd node should stay visible");
secondUniqueAddress.Status.Should().Be(MemberStatus.Up, because: "2nd node should be Up");e4828f1 to
23eff61
Compare
|
Thanks @ismaelhamed ! |
This was referenced Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a quarantined node will be automatically downed and removed from the cluster without the downing provider being aware of the situation.
Port #25678