Skip to content

Don't automatically down quarantined node, #25632 #25678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2018
Merged

Don't automatically down quarantined node, #25632 #25678

merged 1 commit into from
Sep 26, 2018

Conversation

patriknw
Copy link
Contributor

Refs #25632

I'll setup a repeat job for this.

@patriknw
Copy link
Contributor Author

As mentioned in the ticket, it will remain as Unreachable (Terminated, which means that it can't go back to Reachable) and then the ordinary downing provider has to act on that.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Sep 24, 2018
@akka-ci
Copy link

akka-ci commented Sep 24, 2018

Test PASSed.

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Sep 25, 2018
chbatey
chbatey approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

johanandren
johanandren reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be mentioned somewhere in the docs? I looked for quarantine and there is no mention of the downing of quarantined as far as I can see.

@patriknw
Copy link
Contributor Author

What would we document? That we are not downing? I think the expectation should be that we never down automatically.

johanandren
johanandren approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. LGTM then

@patriknw patriknw merged commit d65a90b into master Sep 26, 2018
@patriknw patriknw deleted the wip-25632-down-Terminated-patriknw branch September 26, 2018 11:30
@ismaelhamed ismaelhamed mentioned this pull request Sep 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

+1 more reviewer

@chbatey chbatey chbatey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patriknw @akka-ci @johanandren @chbatey