-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix issue #2440 #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #2440 #2445
Conversation
Remove the packages.config from the .NuGet folder. Remove the NuGet binary, ensuring it is in the .gitignore file.
@SeanFarrow on Mono:
|
…harding.Tests.MultiNode project.
….Multinode project.
…ite.Tests project.
…ireTests project.
…ultiNode project.
…nner.Shared project.
…nner.Shared.Tests project.
…sformation project.
…istentHashRouting project.
…ing project as there not needed.
@SeanFarrow Mono compilation step is still failing, same issue as before. |
@Aaronontheweb,Where is this specifically failing?
I can’t replicate this locally!
From: Aaron Stannard [mailto:notifications@github.com]
Sent: Thursday, January 12, 2017 18:58
To: akkadotnet/akka.net <akka.net@noreply.github.com>
Cc: Sean Farrow <sean.farrow@seanfarrow.co.uk>; Mention <mention@noreply.github.com>
Subject: Re: [akkadotnet/akka.net] Fix issue #2440 (#2445)
@SeanFarrow<https://github.com/SeanFarrow> Mono compilation step is still failing, same issue as before.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2445 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1ftgTrMf4-xm031voRSRnYLdQySBkks5rRnefgaJpZM4Lgtpu>.
|
@SeanFarrow The mono build uses the build.sh file to run the build. It seems the errors originate from that file. As far as i can see, it should download nuget.exe if its not there. But apparently there is a bug in that script. |
Ok, thanks, do you have any idea what the bug is?
From: Arjen Smits [mailto:notifications@github.com]
Sent: Friday, January 13, 2017 07:49
To: akkadotnet/akka.net <akka.net@noreply.github.com>
Cc: Sean Farrow <sean.farrow@seanfarrow.co.uk>; Mention <mention@noreply.github.com>
Subject: Re: [akkadotnet/akka.net] Fix issue #2440 (#2445)
@SeanFarrow<https://github.com/SeanFarrow> The mono build uses the build.sh file to run the build. It seems the errors originate from that file. As far as i can see, it should download nuget.exe if its not there. But apparently there is a bug in that script.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2445 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1fsTqIfpRKEspcwk4OkftGBz7TPkZks5rRyxSgaJpZM4Lgtpu>.
|
It seems that the check that verifies if the nuget.exe is there does not work. Either that, or downloading the nuget.exe fails (or puts it in the wrong directory or something) |
@SeanFarrow the process is still trying to access the `/src/.nuget/NuGet.exe' |
Which project specifically?
There could be a bug in the build.sh script—I don’t have a mono setup to test unfortunately!
From: Aaron Stannard [mailto:notifications@github.com]
Sent: Friday, January 13, 2017 23:56
To: akkadotnet/akka.net <akka.net@noreply.github.com>
Cc: Sean Farrow <sean.farrow@seanfarrow.co.uk>; Mention <mention@noreply.github.com>
Subject: Re: [akkadotnet/akka.net] Fix issue #2440 (#2445)
@SeanFarrow<https://github.com/SeanFarrow> the process is still trying to access the `/src/.nuget/NuGet.exe'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2445 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1frMCv3vqBA0O1Q4rHWle5h-8CcuEks5rSA8pgaJpZM4Lgtpu>.
|
@SeanFarrow me either, but you could check the code for obvious problems, and then abuse our CI integation to let you know if that fixed it ;). Long feedback cycle though. I can take a look this afternoon and see if i can spot any pathing problems. Ill let you know what i find. |
Ah yes. The problem is in the build.sh file. nuget is downloaded as nuget.exe. While further down the process its being called as NuGet.exe (note the difference in capitals). Because its run on a unix machine it fails. The reason current builds do work. Is because the NuGet.exe was already part of the artifacts. So even though the if condition that checks if the exe is there returns false, and it downloads a new version of nuget. There would effectively be 2 versions available side by side. A nuget.exe and a NuGet.exe. (again note the difference in capitals). If you want i can do a PR to fix this. Or you can make it part of this PR. Whatever you want. |
Hi,
I’ll fix this tomorrow, thanks!
From: Arjen Smits [mailto:notifications@github.com]
Sent: Monday, January 16, 2017 15:05
To: akkadotnet/akka.net <akka.net@noreply.github.com>
Cc: Sean Farrow <sean.farrow@seanfarrow.co.uk>; Mention <mention@noreply.github.com>
Subject: Re: [akkadotnet/akka.net] Fix issue #2440 (#2445)
Ah yes. The problem is in the build.sh file. nuget is downloaded as nuget.exe. While further down the process its being called as NuGet.exe (note the difference in capitals). Because its run on a unix machine it fails.
The reason current builds do work. Is because the NuGet.exe was already part of the artifacts. So even though the if condition that checks if the exe is there returns false, and it downloads a new version of nuget. There would effectively be 2 versions available side by side. A nuget.exe and a NuGet.exe. (again note the difference in capitals).
Because you removed the NuGet.exe that was in git, this fails now.
If you want i can do a PR to fix this. Or you can make it part of this PR. Whatever you want.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2445 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1futMDUWqo2LNtq--aEasqSR5YgMVks5rS4cFgaJpZM4Lgtpu>.
|
ow man. You stirred a hornet nest here @SeanFarrow . |
Hi,
Any chance of you fixing?
Cheers
Sean.
From: Arjen Smits [mailto:notifications@github.com]
Sent: Thursday, January 19, 2017 10:01
To: akkadotnet/akka.net <akka.net@noreply.github.com>
Cc: Sean Farrow <sean.farrow@seanfarrow.co.uk>; Mention <mention@noreply.github.com>
Subject: Re: [akkadotnet/akka.net] Fix issue #2440 (#2445)
ow man. You stirred a hornet nest here @SeanFarrow<https://github.com/SeanFarrow> .
Next problem: "./build.sh: line 13: wget: command not found"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2445 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1fgP7UO6gJdv1Px0SKt6qhCOgZpQRks5rTzRGgaJpZM4Lgtpu>.
|
The issue with wget is my fault. We switched Docker containers and wget is not included by default on the new container so we'll have to install it. |
Fixes issue #2440, but does not migrate away form using MSBuild style package restore, I'll do this as a separate issue.