[build system bug fix] locked the NBench runner version used to performance tests #1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ src\.nuget\NuGet.exe update -self | |||
| src\.nuget\NuGet.exe install FAKE -ConfigFile src\.nuget\Nuget.Config -OutputDirectory src\packages -ExcludeVersion -Version 4.16.1 | |||
|
|
|||
| src\.nuget\NuGet.exe install xunit.runner.console -ConfigFile src\.nuget\Nuget.Config -OutputDirectory src\packages\FAKE -ExcludeVersion -Version 2.0.0 | |||
| src\.nuget\NuGet.exe install NBench.Runner -OutputDirectory src\packages -ExcludeVersion | |||
| src\.nuget\NuGet.exe install NBench.Runner -OutputDirectory src\packages -ExcludeVersion -Version 0.1.5 | |||
There was a problem hiding this comment.
Locked on 0.1.5 - will need to be upgraded later if we update the version of NBench
JeffCyr
added a commit
that referenced
this pull request
Feb 16, 2016
[build system bug fix] locked the NBench runner version used to performance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of NBench v0.1.6 yesterday introduced a redesign of how tests are loaded (isolated AppDomains) and that broke compatibility between the runner and the test dll. This locks the runner version to the version we're using in our tests and is needed in order to get CI to pass.