Remote ActorRef Provider Fix for #1646 #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace patternmatch
| base.TellInternal(send.Message, send.SenderOption ?? ActorRefs.NoSender); | ||
| } | ||
| } | ||
| else if (deadLetter?.Message is EndpointManager.Send) |
There was a problem hiding this comment.
I've replaced the pattern matching code with normal if blocks, this specific check only consumes deadletters containing EndpointManager.Send messages now.
(unlike before where it incorrectly consumed all deadletters)
|
See Scala code for ref implementation override def !(message: Any)(implicit sender: ActorRef): Unit = message match {
case Send(m, senderOption, _, seqOpt) ⇒
// else ignore: it is a reliably delivered message that might be retried later, and it has not yet deserved
// the dead letter status
if (seqOpt.isEmpty) super.!(m)(senderOption.orNull)
case DeadLetter(Send(m, senderOption, recipient, seqOpt), _, _) ⇒
// else ignore: it is a reliably delivered message that might be retried later, and it has not yet deserved
// the dead letter status
if (seqOpt.isEmpty) super.!(m)(senderOption.orNull)
case _ ⇒ super.!(message)(sender)
} |
|
I've reviewed this and yep, the bug is pretty clearly a greedy match statement and @rogeralsing's fix matches the JVM source. Merging it in prior to 1.0.6. |
Aaronontheweb
added a commit
that referenced
this pull request
Jan 18, 2016
Remote ActorRef Provider Fix for #1646
|
Crap, hit the wrong button the first time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1646
In the
RemoteDeadletterActorRefthere is some missing code to propagate deadletters to the base implementation: