#1365 added untrustedspec #1552
Conversation
e7223a7 to
eee6b71
Compare
|
Perf issues will be fixed by #1560 once that's merged |
|
@maxim-s could you rebase this on dev? should resolve the issue with the failing spec |
eee6b71 to
22948c0
Compare
|
@Aaronontheweb done |
|
Looks good but unclear (to me) why the F# API changes are for? |
|
@maxim-s @Horusiath what's up with the F# API changes in this pr, as @rogeralsing asked? |
|
@rogeralsing @Horusiath @Aaronontheweb I've changed F# API because, one new method |
|
@rogeralsing @Horusiath that interface change won't create any issues will it? I think it's safe to add new members but would love to get a second opinion on that. Otherwise, I'm good to go with this PR. Ready for merge as soon as that question is answered. |
|
@Aaronontheweb the interface change will break any user defined class that implements the interface, which is the reason MS is moving away from interfaces in vNext in favor for abstract classes, as you can add new members with a default impl. That being said, I would be extremely surprised if anyone have implemented their own custom actorrreffactory. |
|
I can implement it without breaking changes |
22948c0 to
5cc5d26
Compare
|
@Aaronontheweb @rogeralsing Updated without changing interface |
|
@maxim-s build server didn't pick it up due to the older commit date - could you please rebase 1 more time and run this command? This will refresh the timestamp and cause the build server to detect it: |
|
Nevermind Maxim, looks like this was an issue with Azure. Apparently our Azure cloud service we use for auto-scaling build agents was permanently faulted by something that occurred at midnight 12/31. Switched to a new cloud service and everything is running correctly again. |
ac395c0 to
8a2155f
Compare
|
@Aaronontheweb updated |
8a2155f to
ace4976
Compare
| /// </summary> | ||
| public static ActorSelection ActorSelection(this IActorRefFactory factory, IActorRef anchorRef, string actorPath) | ||
| { | ||
| return ActorRefFactoryShared.ActorSelection(anchorRef, actorPath); |
There was a problem hiding this comment.
Brand new extension method - not a breaking change. Should be fine.
|
@maxim-s looks good - could you rebase this on http://getakka.net/docs/akka-developers/public-api-changes Also left a couple of comments for you |
ace4976 to
afa0a28
Compare
afa0a28 to
25e5fe1
Compare
|
@Aaronontheweb updated |
…e-untrusted-mode-fix #1365 added untrustedspec
fixed dropping inbound actor selection in the untrusted mode
https://github.com/akka/akka/blob/master/akka-remote/src/main/scala/akka/remote/Endpoint.scala#L79
fixed dropping inbound PossiblyHarmful message
https://github.com/akka/akka/blob/master/akka-remote/src/main/scala/akka/remote/Endpoint.scala#L86
added path to remote daemon
https://github.com/akka/akka/blob/master/akka-remote/src/main/scala/akka/remote/RemoteActorRefProvider.scala#L167
added actor selection by given target
replaced type matching to if else , for doing complicated conditions