akka-io: Stop select loop on idle #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case SocketAsyncOperation.Receive: | ||
| Execute(() => | ||
| { | ||
| _read.Add(channel.Socket, channel); |
There was a problem hiding this comment.
this looks racy to me, _read is a dictionary and is now mutated on another thread.
Or?
There was a problem hiding this comment.
All access to _read and _write are currently on a single thread - the one used for the select loop.
rogeralsing
added a commit
that referenced
this pull request
Aug 12, 2015
akka-io: Stop select loop on idle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes #1225. The select loop is now only started once sockets are registered for selection, and stopped when no sockets are interested anymore.