Skipped tests are bad
On Sat, Aug 8, 2015 at 2:41 AM Suhas Chatekar notifications@github.com
wrote:

#1088 #1088 MultiNode
tests can now be skipped by specifying a SkipReason

I have learned that XUnit works in two phases - discovery of tests and
execution of tests.

The tests that are to be skipped are skipped during execution and not
discovery. I believe this is because you would want to show a message that
a test was not executed but skipped for a particular reason. Since
MultiNodeTestRunner has its own test execution logic, a change was needed

in that logic to skip the tests.

You can view, comment on, or merge this pull request online at:

#1221
Commit Summary

• Skip attribute on MultiNodeFact does not work #1088 MultiNode tests can now be skipped by specifying a SkipReason

File Changes

• M src/core/Akka.MultiNodeTestRunner.Shared/NodeTest.cs
  https://github.com/akkadotnet/akka.net/pull/1221/files#diff-0 (1)
• M src/core/Akka.MultiNodeTestRunner/Discovery.cs
  https://github.com/akkadotnet/akka.net/pull/1221/files#diff-1 (3)
• M src/core/Akka.MultiNodeTestRunner/Program.cs
  https://github.com/akkadotnet/akka.net/pull/1221/files#diff-2 (6)
• M src/core/Akka.MultiNodeTests/MultiNodeFact.cs
  https://github.com/akkadotnet/akka.net/pull/1221/files#diff-3 (2)

Patch Links:

• https://github.com/akkadotnet/akka.net/pull/1221.patch
• https://github.com/akkadotnet/akka.net/pull/1221.diff

—
Reply to this email directly or view it on GitHub
#1221.

@annymsMthd I get the point but a mechanism is needed to stop the randomly failing tests from failing the build until we fix them.

👍

@annymsMthd currently the clustered router tests are skipped - there's something inherently racy with the tests themselves.