Skip to content

docs: Fix broken samples #32667 #32668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2025
Merged

docs: Fix broken samples #32667 #32668

merged 3 commits into from
Feb 24, 2025

Conversation

johanandren
Copy link
Contributor

References #32667

@johanandren johanandren changed the title docs: Fix incorrect sharding sample dependencies #32667 docs: Fix broken samples #32667 Feb 24, 2025
patriknw
patriknw approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit 4c87a1e into main Feb 24, 2025
5 checks passed
@johanandren johanandren deleted the wip-fix-killrweather-deps branch February 24, 2025 11:09
johanandren added a commit that referenced this pull request Feb 24, 2025
@johanandren
docs: Fix broken samples #32667 (#32668)
c5146bd 
* docs: Fix incorrect sharding sample dependencies #32667

* some fixes to the kafka sample as well

* Some more dependency bumps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanandren @patriknw