fix: Multiple potential issues with the tcp DNS client #32636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
leviramsey
approved these changes
Feb 3, 2025
patriknw
approved these changes
Feb 3, 2025
| } else { | ||
| val oldest = requestBuffer.head | ||
| val newRequestBuffer = requestBuffer.tail :+ msg | ||
| log.warning("Dropping oldest buffered DNS request [{}] due to TCP backpressure", oldest) |
There was a problem hiding this comment.
ok to log the ByteString? anything sensitive in those?
There was a problem hiding this comment.
It's the DNS query Message, I can't think of any way that would be sensitive (and that we don't already log in a ton of places)
sebastian-alfers
pushed a commit
to sebastian-alfers/akka
that referenced
this pull request
Feb 4, 2025
* fix: improve TCP DNS client interactions with TCP actor * ensure that TCP connection is closed when TcpDnsClient fails * Fix for potential re-order of response bytes during high load * Deathwatch the connection to make sure we are never stuck in a broken state --------- Co-authored-by: Levi Ramsey <levi.ramsey@alum.cs.umass.edu>
johanandren
added a commit
that referenced
this pull request
Feb 4, 2025
* fix: improve TCP DNS client interactions with TCP actor * ensure that TCP connection is closed when TcpDnsClient fails * Fix for potential re-order of response bytes during high load * Deathwatch the connection to make sure we are never stuck in a broken state --------- Co-authored-by: Johan Andrén <johan@markatta.com> Co-authored-by: Levi Ramsey <levi.ramsey@alum.cs.umass.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #32635