Skip to content

Fix lookup of coordinator for sharding proxies #23995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2017
Merged

Fix lookup of coordinator for sharding proxies #23995

merged 1 commit into from
Nov 15, 2017

Conversation

chbatey
Copy link
Contributor

@chbatey chbatey commented Nov 14, 2017

Refs #23741

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Nov 14, 2017
@akka-ci
Copy link

akka-ci commented Nov 14, 2017

Test FAILed.

@chbatey
Copy link
Contributor Author

chbatey commented Nov 14, 2017

PLS BUILD

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Nov 14, 2017
@akka-ci
Copy link

akka-ci commented Nov 14, 2017

Test PASSed.

@patriknw patriknw mentioned this pull request Nov 15, 2017
Merged
patriknw
patriknw approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

johanandren
johanandren approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chbatey chbatey merged commit 1eb3abb into akka:master Nov 15, 2017
@chbatey chbatey deleted the proxy-sharding-broken branch November 15, 2017 13:03
manonthegithub pushed a commit to manonthegithub/akka that referenced this pull request Jan 31, 2018
@chbatey @manonthegithub
Fix lookup of coordinator for sharding proxies (akka#23995)
6c8afc8
zbynek001 added a commit to zbynek001/akka.net that referenced this pull request Jun 24, 2018
@zbynek001
Separate sharding regions and proxies
2310d5a 
akka/akka#23472

Fix lookup of coordinator for sharding proxies
akka/akka#23995
@zbynek001 zbynek001 mentioned this pull request Jun 24, 2018
Merged
Aaronontheweb pushed a commit to akkadotnet/akka.net that referenced this pull request Jun 25, 2018
@zbynek001 @Aaronontheweb
Sharding update (#3524)
41c116d 
* Provide access to known shard types
akka/akka#23912

* Separate sharding regions and proxies
akka/akka#23472

Fix lookup of coordinator for sharding proxies
akka/akka#23995

* Fix race in ClusterShardingFailureSpec

AFAICT there was nothing ensuring the order of messages when sent to the
shard and the region so first checkthat the passivation has happened
before sending another add in the test
akka/akka#24013

* Better warning message on cluster sharding registration
akka/akka#24906

* entityId => Behavior in ClusterSharding API
mixture of
akka/akka#24053
akka/akka#21809
akka/akka#24470

* sharding tests updated

* headers fixed, docs updated

* ClusterSharding: automatically choose start or startProxy by a node role
akka/akka#23934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chbatey @akka-ci @patriknw @johanandren