Skip to content

#22030 Lazy sink wait for init agolubev #22033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2017
Merged

#22030 Lazy sink wait for init agolubev #22033

merged 2 commits into from
Feb 16, 2017

Conversation

agolubev
Copy link
Contributor

ref #22030
It's problematic to write good test for this case - so I left one from #22018

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Dec 16, 2016
@akka-ci
Copy link

akka-ci commented Dec 16, 2016

Test FAILed.

@akka-ci akka-ci removed the validating PR is currently being validated by Jenkins label Dec 16, 2016
@agolubev
Copy link
Contributor Author

Remote test failed

drewhk
drewhk approved these changes Feb 10, 2017
View reviewed changes
Copy link
Contributor

@drewhk drewhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

johanandren
johanandren approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanandren
Copy link
Contributor

PLS BUILD

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Feb 15, 2017
@akka-ci
Copy link

akka-ci commented Feb 15, 2017

Test PASSed.

@johanandren johanandren merged commit 552481b into akka:master Feb 16, 2017
@johanandren johanandren added this to the 2.5.0 milestone Feb 16, 2017
@johanandren johanandren mentioned this pull request Feb 16, 2017
Merged
@ktoso
Copy link
Contributor

ktoso commented Feb 16, 2017

Awesome, thanks!

@agolubev
Copy link
Contributor Author

That's great. Thank you.

This was referenced Jun 5, 2017
Closed
Closed
Merged
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Jun 8, 2017
@Arkatufus
akka/akka#22033, FileSinkSpec scala port to C#
128418b
@alexvaluyskiy alexvaluyskiy mentioned this pull request Jun 10, 2017
Closed
21 tasks
Aaronontheweb pushed a commit to Aaronontheweb/akka.net that referenced this pull request Jun 28, 2017
@Arkatufus @Aaronontheweb
akka/akka#22033, FileSinkSpec scala port to C#
5ffc7ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

+1 more reviewer

@drewhk drewhk drewhk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins to-be-backported
Projects
None yet
Milestone
2.5-M2
Development

Successfully merging this pull request may close these issues.
6 participants
@agolubev @akka-ci @johanandren @ktoso @drewhk @jbgi