=clut #24311 timer event may arrive after we already identified successfuly #24442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
patriknw
approved these changes
Jan 30, 2018
|
Yeap, agreed, trying to keep change at a minimum here, at least for now |
|
Perhaps add the NoSerializationVerficationNeeded to |
|
Yup, added |
|
After reading the ticket again, this actually fixes one somewhat more annoying thing than unhandled: "this matches case msg: Any ⇒ so ClusterSingletonProxy will try to send TryToIdentifySingleton to the singleton" That is also harmless, apart from that it would actually try to serialize the TryToIdentifySingleton when sending as a real remote message. |
|
Yeah, it guards from it to fall through to that case. Added the no serialization check anyway, good to mark it such. |
|
Test PASSed. |
manonthegithub
pushed a commit
to manonthegithub/akka
that referenced
this pull request
Jan 31, 2018
…uccessfuly (akka#24442) * =clut akka#24311 timer event may arrive after we already identified successfuly * mark as NoSerializationVerificationNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24311
I think it is indeed right to accept the message and simply ignore it, like Johan has suggested in the ticket.
Could not think of an useful way of testing it, should I try harder?