add missing returnRecoveryPermit #24439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* missing for some error cases * in the states recoveryStarted and recovering it has got the permit and it must returned if the actor is stopped due to some error in those states * it would have been a lot easier to do such in postStop but we can't introduce new things in the trait Eventsourced due to BC
|
Test PASSed. |
ktoso
reviewed
Jan 30, 2018
|
|
||
| case RecoveryTick(true) ⇒ | ||
| try onRecoveryFailure( | ||
| new RecoveryTimedOut(s"Recovery timed out, didn't get snapshot within $timeout"), | ||
| event = None) | ||
| finally context.stop(self) | ||
| returnRecoveryPermit() |
There was a problem hiding this comment.
should those be in the finally blocks? in case a class implements onRecoveryFailure and ends up throwing for some reason, we still want to return the token.
Great catch btw, I'll make sure to have those covered in the typed one
There was a problem hiding this comment.
There is a catch surrounding the whole message processing that will handle that case. In typed I assume this will be a lot easier because we don't have the restriction of not being able to introduce new state variables as we have in the Eventsourced trait.
There was a problem hiding this comment.
Ah good, yeah indeed somewhat messy. Thanks!
ktoso
approved these changes
Jan 30, 2018
johanandren
approved these changes
Jan 30, 2018
manonthegithub
pushed a commit
to manonthegithub/akka
that referenced
this pull request
Jan 31, 2018
* missing for some error cases * in the states recoveryStarted and recovering it has got the permit and it must returned if the actor is stopped due to some error in those states * it would have been a lot easier to do such in postStop but we can't introduce new things in the trait Eventsourced due to BC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it must returned if the actor is stopped due to some error in those
states
introduce new things in the trait Eventsourced due to BC